OTA download and decompress on the fly #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
per1234
added
type: enhancement
andreagilardoni
force-pushed
the
lzss-streaming
branch
5 times, most recently
from
cdfa12a to
085768d
Compare
pennam
requested changes
Jan 16, 2024
There was a problem hiding this comment.
@andreagilardoni i've tested the code and it works. Just a couple of minor things that i think can be improved:
- commit history can be improved a little bit more. All subsequentials changes to the LZSSDecoder can be squashed in a single commit.
- Alway put a space after
iffor... to be consistent to the code style
| } ota_progress; | ||
|
|
||
| int bytes = socket->download(url, is_https, [&decoder, &ota_header, &ota_progress](const char* buffer, uint32_t size) { | ||
| for(char* cursor=(char*)buffer; cursor<buffer+size; ) { |
There was a problem hiding this comment.
I think you can directly declare cursor as uint8_t* and also cast buffer to uint8_t* this should avoid cast in line 177
There was a problem hiding this comment.
The correct approach will be to define buffer as char* const, but this requires lots of changes in the core code. Then cast cursor to uint8_t* in decompress call
andreagilardoni
force-pushed
the
lzss-streaming
branch
2 times, most recently
from
34304da to
394c825
Compare
pennam
reviewed
Jan 16, 2024
Comment on lines
+85
to
+91
| enum FSM_STATES: uint8_t { | ||
| FSM_0 = 0, | ||
| FSM_1 = 1, | ||
| FSM_2 = 2, | ||
| FSM_3 = 3, | ||
| FSM_EOF | ||
| } state; |
There was a problem hiding this comment.
@andreagilardoni i would give a more meaningful name to this FSM states if it possible
There was a problem hiding this comment.
There are no meaningful names for those states
|
@andreagilardoni CI is failing because is using an old deprecated mbed core for portenta. See |
andreagilardoni
force-pushed
the
lzss-streaming
branch
2 times, most recently
from
eb58243 to
6038ad6
Compare
andreagilardoni
force-pushed
the
lzss-streaming
branch
3 times, most recently
from
e7a8d74 to
9c13139
Compare
The objective of this implementation is to provide a more versatile way of handling decompression of lzss streams of data. The main reason is to allow streaming decompression
…old implementation
andreagilardoni
force-pushed
the
lzss-streaming
branch
from
9c13139 to
f3db4bc
Compare
|
Memory usage change @ f3db4bc
Click for full report table
Click for full report CSV |
pennam
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to provide a easy to use utility class
LZSSDecoderthat can be used to perform an OTA update on the fly.Since in the mbed core we provide apis for http download using callbacks it was required to adapt the code for the decode function.
Some examples for the usage of
LZSSDecoderwere added and they made it possible to measure the performance improvements obtained from a sequential download and decompress to a download and decompress on the fly:This way the OTA download and decompress operations now take 35% of the time.
This PR requires arduino/ArduinoCore-mbed#785