Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

Use the Arduino_MachineControl library on the M4 core of PMC #99

Closed
wants to merge 1 commit into from
Closed

Use the Arduino_MachineControl library on the M4 core of PMC #99

wants to merge 1 commit into from

Conversation

elastra21
Copy link

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@elastra21 elastra21 changed the title Is a way to use the Arduino_MachineControl on the M4 core of PMC There's a way to use the Arduino_MachineControl library on the M4 core of PMC Oct 26, 2022
@elastra21 elastra21 changed the title There's a way to use the Arduino_MachineControl library on the M4 core of PMC Use the Arduino_MachineControl library on the M4 core of PMC Oct 26, 2022
@per1234 per1234 linked an issue Oct 26, 2022 that may be closed by this pull request
Dual Core Example/Functionality #85
Open
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Oct 26, 2022
@github-actions
Copy link

Memory usage change @ 589becb

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m7 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Analog_Out
flash		 % examples/Analog_Out
RAM for global variables		 % examples/Analog_input/Analog_input_0_10V
flash		 % examples/Analog_input/Analog_input_0_10V
RAM for global variables		 % examples/Analog_input/Analog_input_4_20mA
flash		 % examples/Analog_input/Analog_input_4_20mA
RAM for global variables		 % examples/Analog_input/Analog_input_NTC
flash		 % examples/Analog_input/Analog_input_NTC
RAM for global variables		 % examples/CAN/ReadCan
flash		 % examples/CAN/ReadCan
RAM for global variables		 % examples/CAN/WriteCan
flash		 % examples/CAN/WriteCan
RAM for global variables		 % examples/Digital_output
flash		 % examples/Digital_output
RAM for global variables		 % examples/Digital_programmable/CombinedIOExpander
flash		 % examples/Digital_programmable/CombinedIOExpander
RAM for global variables		 % examples/Digital_programmable/Digital_input
flash		 % examples/Digital_programmable/Digital_input
RAM for global variables		 % examples/Digital_programmable/GPIO_programmable
flash		 % examples/Digital_programmable/GPIO_programmable
RAM for global variables		 % examples/Encoders
flash		 % examples/Encoders
RAM for global variables		 % examples/Ethernet
flash		 % examples/Ethernet
RAM for global variables		 % examples/RS232
flash		 % examples/RS232
RAM for global variables		 % examples/RS485_fullduplex
flash		 % examples/RS485_fullduplex
RAM for global variables		 % examples/RS485_halfduplex
flash		 % examples/RS485_halfduplex
RAM for global variables		 % examples/RTC
flash		 % examples/RTC
RAM for global variables		 % examples/RTC_Alarm
flash		 % examples/RTC_Alarm
RAM for global variables		 % examples/Temp_probes_RTD
flash		 % examples/Temp_probes_RTD
RAM for global variables		 % examples/Temp_probes_Thermocouples
flash		 % examples/Temp_probes_Thermocouples
RAM for global variables		 % examples/USB_host
flash		 % examples/USB_host
RAM for global variables		 %
arduino:mbed_portenta:envie_m7 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/Analog_Out<br>flash,%,examples/Analog_Out<br>RAM for global variables,%,examples/Analog_input/Analog_input_0_10V<br>flash,%,examples/Analog_input/Analog_input_0_10V<br>RAM for global variables,%,examples/Analog_input/Analog_input_4_20mA<br>flash,%,examples/Analog_input/Analog_input_4_20mA<br>RAM for global variables,%,examples/Analog_input/Analog_input_NTC<br>flash,%,examples/Analog_input/Analog_input_NTC<br>RAM for global variables,%,examples/CAN/ReadCan<br>flash,%,examples/CAN/ReadCan<br>RAM for global variables,%,examples/CAN/WriteCan<br>flash,%,examples/CAN/WriteCan<br>RAM for global variables,%,examples/Digital_output<br>flash,%,examples/Digital_output<br>RAM for global variables,%,examples/Digital_programmable/CombinedIOExpander<br>flash,%,examples/Digital_programmable/CombinedIOExpander<br>RAM for global variables,%,examples/Digital_programmable/Digital_input<br>flash,%,examples/Digital_programmable/Digital_input<br>RAM for global variables,%,examples/Digital_programmable/GPIO_programmable<br>flash,%,examples/Digital_programmable/GPIO_programmable<br>RAM for global variables,%,examples/Encoders<br>flash,%,examples/Encoders<br>RAM for global variables,%,examples/Ethernet<br>flash,%,examples/Ethernet<br>RAM for global variables,%,examples/RS232<br>flash,%,examples/RS232<br>RAM for global variables,%,examples/RS485_fullduplex<br>flash,%,examples/RS485_fullduplex<br>RAM for global variables,%,examples/RS485_halfduplex<br>flash,%,examples/RS485_halfduplex<br>RAM for global variables,%,examples/RTC<br>flash,%,examples/RTC<br>RAM for global variables,%,examples/RTC_Alarm<br>flash,%,examples/RTC_Alarm<br>RAM for global variables,%,examples/Temp_probes_RTD<br>flash,%,examples/Temp_probes_RTD<br>RAM for global variables,%,examples/Temp_probes_Thermocouples<br>flash,%,examples/Temp_probes_Thermocouples<br>RAM for global variables,%,examples/USB_host<br>flash,%,examples/USB_host<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@akash73 akash73 requested a review from facchinm November 14, 2022 16:55
@facchinm
Copy link
Collaborator

facchinm commented Nov 21, 2022 •
edited
Loading

I'd rather fix at core level with something like

diff --git a/variants/PORTENTA_H7_M4/pins_arduino.h b/variants/PORTENTA_H7_M4/pins_arduino.h
index 97a055d4..b99d9cc8 100644
--- a/variants/PORTENTA_H7_M4/pins_arduino.h
+++ b/variants/PORTENTA_H7_M4/pins_arduino.h
@@ -135,6 +135,11 @@ void _ontouch1200bps_();
 
 #define digitalPinToPort(P)            (digitalPinToPinName(P)/16)
 
+#define SERIAL_PORT_USBVIRTUAL      Serial
+#define SERIAL_PORT_MONITOR         Serial
+#define SERIAL_PORT_HARDWARE        Serial
+#define SERIAL_PORT_HARDWARE_OPEN   Serial1
+
 #define CRYPTO_WIRE            Wire1
 
 #endif //__PINS_ARDUINO__

@elastra21
Copy link
Author

@facchinm Well that it'll be a better solution but for now I mean to allow to all the developers keep working would be great to fix that issue even if is a temporal patch. I found the solution months ago and right know that I start to work again with the PMC was complicated to find it again.

@facchinm
Copy link
Collaborator

Fixed by arduino/ArduinoCore-mbed@d9ce942 , will be available in the upcoming core release (3.5.x)

@facchinm facchinm closed this Nov 28, 2022
@per1234 per1234 added the conclusion: resolved Issue was resolved label Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facchinm facchinm Awaiting requested review from facchinm

Assignees
No one assigned
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dual Core Example/Functionality
4 participants
@elastra21 @CLAassistant @facchinm @per1234