Fixing ADC initialization function to work properly on Portenta H7 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Memory usage change @ 123f0c1
Click for full report table
Click for full report CSV |
karlsoderby
reviewed
Nov 29, 2023
There was a problem hiding this comment.
Hey @leonardocavagnis I've reviewed the documentation part and it looks great. Left some small suggestions :)
|
Memory usage change @ 7a21328
Click for full report table
Click for full report CSV |
|
Hi @leonardocavagnis can you please squash all of the docs update commits into one commit ? |
Update docs/readme.md Update docs/readme.md Update docs/readme.md Update docs/readme.md update docs/readme.md: add multichannel description doc: update README.md doc: update doc/readme.md Co-Authored-By: Karl Söderby <[email protected]>
leonardocavagnis
force-pushed
the
adc_config_fix
branch
from
7a21328 to
0bf0e0a
Compare
|
Memory usage change @ 0bf0e0a
Click for full report table
Click for full report CSV |
|
@karlsoderby @leonardocavagnis Why are we removing most of the |
I removed it according to the Arduino Library guideline. Most of the information has been moved in the |
iabdalkader
requested changes
Dec 5, 2023
Update src/AdvancedADC.cpp Update src/AdvancedADC.cpp Update src/AdvancedADC.cpp Update src/AdvancedADC.cpp Update src/AdvancedADC.cpp Update src/AdvancedADC.cpp Update src/AdvancedADC.cpp Update src/AdvancedADC.cpp Update src/HALConfig.cpp Update src/AdvancedADC.cpp Update src/AdvancedADC.cpp Co-Authored-By: Ibrahim Abdelkader <[email protected]>
leonardocavagnis
force-pushed
the
adc_config_fix
branch
from
854e744 to
065318b
Compare
leonardocavagnis
added
type: imperfection
|
Memory usage change @ 065318b
Click for full report table
Click for full report CSV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
adc.begin()function to allow properly working on Portenta H7adc.begin()functionREADME.mdaccording to the Arduino library guidelinedocs/readme.mdThe PR is based on the ArduinoCore-mbed patch related to arduino/mbed-os PR#34.
Please,
@iabdalkader take a look to
adc.begin()modifies@karlsoderby check if
docs/readme.mdsounds good for you