Actually check remote DHKey

arduino-libraries · Jan 3, 2021 · 750b7f1 · 750b7f1
1 parent 0aa2e87
commit 750b7f1
Show file tree

Hide file tree

Showing 2 changed files with 58 additions and 13 deletions.
diff --git a/src/utility/HCI.cpp b/src/utility/HCI.cpp
@@ -24,6 +24,8 @@
 #include "btct.h"
 #include "HCI.h"
 
+//#define _BLE_TRACE_
+
 #define HCI_COMMAND_PKT   0x01
 #define HCI_ACLDATA_PKT   0x02
 #define HCI_EVENT_PKT     0x04
@@ -1408,13 +1410,34 @@ void HCIClass::handleEventPkt(uint8_t /*plen*/, uint8_t pdata[])
             btct.printBytes(MasterIOCap, 3);
             Serial.println("Send Eb Back.");
 #endif
-            uint8_t ret[17];
-            ret[0] = 0x0d;
-            for(int i=0; i<sizeof(Eb); i++){
-              ret[sizeof(Eb)-i] = Eb[i];
+            // Check if RemoteDHKeyCheck = Ea
+            bool EaCheck = true;
+            for(int i = 0; i < 16; i++){
+              if (Ea[i] != HCI.remoteDHKeyCheckBuffer[i]){	        
+                EaCheck = false;
+              }
+            }
+
+            if (EaCheck){
+              // Send our confirmation value to complete authentication stage 2
+              uint8_t ret[17];
+              ret[0] = CONNECTION_PAIRING_DHKEY_CHECK;
+              for(int i=0; i<sizeof(Eb); i++){
+                ret[sizeof(Eb)-i] = Eb[i];
+              }
+              HCI.sendAclPkt(connectionHandle, SECURITY_CID, sizeof(ret), ret );
+              ATT.setPeerEncryption(connectionHandle, encryption | PEER_ENCRYPTION::SENT_DH_CHECK);
+
+	  } else {
+              // If check fails, abort
+#ifdef _BLE_TRACE_
+        Serial.println("Error: DHKey check failed - Aborting");
+#endif
+              uint8_t ret[2] = {CONNECTION_PAIRING_FAILED, 0x0B}; // DHKey Check Faile
+              HCI.sendAclPkt(connectionHandle, SECURITY_CID, sizeof(ret), ret);
+              ATT.setPeerEncryption(connectionHandle, NO_ENCRYPTION);
             }
-            HCI.sendAclPkt(connectionHandle, 0x06, sizeof(ret), ret );
-            ATT.setPeerEncryption(connectionHandle, encryption | PEER_ENCRYPTION::SENT_DH_CHECK);
+
           }else{
 #ifdef _BLE_TRACE_
             Serial.println("Waiting on other DHKey check before calculating.");

diff --git a/src/utility/L2CAPSignaling.cpp b/src/utility/L2CAPSignaling.cpp
@@ -26,6 +26,8 @@
 #define CONNECTION_PARAMETER_UPDATE_REQUEST  0x12
 #define CONNECTION_PARAMETER_UPDATE_RESPONSE 0x13
 
+//#define _BLE_TRACE_
+
 L2CAPSignalingClass::L2CAPSignalingClass() :
   _minInterval(0),
   _maxInterval(0),
@@ -353,14 +355,34 @@ void L2CAPSignalingClass::handleSecurityData(uint16_t connectionHandle, uint8_t
       btct.printBytes(MasterIOCap, 3);
       Serial.println("Send Eb Back.");
 #endif
-
-      uint8_t ret[17];
-      ret[0] = 0x0d;
-      for(int i=0; i<sizeof(Eb); i++){
-        ret[sizeof(Eb)-i] = Eb[i];
+
+      // Check if RemoteDHKeyCheck = Ea
+      bool EaCheck = true;
+      for(int i = 0; i < 16; i++){
+        if (Ea[i] != RemoteDHKeyCheck[i]){	        
+	EaCheck = false;
+        }
+      }
+
+      if (EaCheck){
+        // Send our confirmation value to complete authentication stage 2
+        uint8_t ret[17];
+        ret[0] = CONNECTION_PAIRING_DHKEY_CHECK;
+        for(int i=0; i<sizeof(Eb); i++){
+          ret[sizeof(Eb)-i] = Eb[i];
+        }
+        HCI.sendAclPkt(connectionHandle, SECURITY_CID, sizeof(ret), ret );
+        ATT.setPeerEncryption(connectionHandle, encryptionState | PEER_ENCRYPTION::SENT_DH_CHECK);
+
+      } else {
+        // If check fails, abort
+#ifdef _BLE_TRACE_
+        Serial.println("Error: DHKey check failed - Aborting");
+#endif
+        uint8_t ret[2] = {CONNECTION_PAIRING_FAILED, 0x0B}; // DHKey Check Faile
+        HCI.sendAclPkt(connectionHandle, SECURITY_CID, sizeof(ret), ret);
+        ATT.setPeerEncryption(connectionHandle, NO_ENCRYPTION);
       }
-      HCI.sendAclPkt(connectionHandle, 0x06, sizeof(ret), ret );
-      ATT.setPeerEncryption(connectionHandle, encryptionState | PEER_ENCRYPTION::SENT_DH_CHECK);
     }
   }
 }