fix: clean up observableToAsyncIterable state when observable completes#8057
Draft
fix: clean up observableToAsyncIterable state when observable completes#8057
Conversation
🦋 Changeset detectedLatest commit: 6773282 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…letes Co-authored-by: ardatan <20847995+ardatan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix action job issue
fix: clean up observableToAsyncIterable state when observable completes
Mar 18, 2026
Contributor
💻 Website PreviewThe latest changes are available as preview in: https://pr-8057.graphql-tools.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Leak Test CI job was failing non-deterministically because
observableToAsyncIterablenever released its internal queues and subscription when the observable sent adone: truesignal — leaving those references alive past the end of the test, causing Jest's--detectLeaksto flag the test suite.Changes
pullValue(): When shifting adone: trueelement offpushQueue, callemptyQueue()before resolving — clearingpullQueue,pushQueue, unsubscribing, and settinglistening = falseimmediately rather than waiting for the iterator to be explicitlyreturn()ed.pushDone(): After resolving a pending consumer (pulled frompullQueue) with the done signal, callemptyQueue()to release any remaining state.The forward references to
emptyQueueare safe: both code paths are only reachable after the iterator has been returned to the caller, which is afteremptyQueueis defined.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.