Use rebar3_erlydtl_plugin #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Uses official rebar3 plugin for erlydtl - Removes escriptize hook so it compiles under `rebar3 bare compile` used by Mix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches over to using the officially recommended rebar3 plugin for erlydtl, and simultaneously addresses an issue which prevents
edumpfrom compiling under Mix.Mix uses
rebar3 bare compile --paths <path>, and as far as I can tell, this prevents a post hook of{compile, {default, escriptize}}or{compile, escriptize}from working. The latter doesn't work at all (it complains about escriptize being unavailable), and the former fails during the escriptize task because it is unable to find the .app file for dependencies, since it is ignoring the bare configuration which overrides the paths (at least that's my assumption). It ends up looking in the local_build/default/...path, rather than in the path provided viarebar3 bare compile --paths <path>, and of course there is nothing there.The fix for this last bit is to simply remove the escriptize hook for now, since I suspect it's not that important that it be automatically escriptized when compiling, and anyone who wants the escript can just run
rebar3 escriptizethemselves, and this allows other libraries to include edump. In my particular case, I want to provide a plugin for Distillery which includesedumpin a release, and exposes abin/myapp edump <path to crash dump>command. Right now I can't do that, since it isn't possible to compile a Mix project withedumpas a dependency.Let me know if you have any questions or concerns, I'm happy to help work it out!