Authenticate at app launch - #15
Open
demonkillerr wants to merge 6 commits into
Open
Conversation
Member
|
I think I am not sure about the raw root password being stored in application memory ( I mean if the goal is to avoid multiple authentication prompts during a session, we shouldn't build a custom credential cache in user-space memory. Instead we can rely on native
I think it is worth considering this pattern instead. What do you think? |
Member
Author
|
Yes, this should be the approach. Can you file a PR please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to request for user's password only at app launch. Thereafter, the application will use cached password instead of pkexec. This change makes the user's life easy, as they do not need to authenticate multiple times for multiple operations.
The Implementation is a single-prompt authentication model at application startup using a new
AuthManagersingleton class. All privileged operations now usesudo -Swith the cached password instead ofpkexec, reducing authentication prompts and improving user experience.Changes:
AuthManagerclass: prompts for password once at startup, validates viasudo -S, stores securely in memoryMainWindowconstructor: exits gracefully if user cancelsPackageManager: all package operations now use sudo -S with password pipingSettingsWidget: all 9 privilege escalation calls replaced with sudo -SpkexecreferencesUser benefits: