Supervised Buffer implementation #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchacki
approved these changes
Aug 18, 2025
Member
mchacki
left a comment
mchacki
left a comment
There was a problem hiding this comment.
LGTM, no production change in this repository.
mchacki
requested changes
Aug 18, 2025
Member
mchacki
left a comment
mchacki
left a comment
There was a problem hiding this comment.
Correction:
I think you need to make "clear" virtual as well, it can mess with the capacity in one branch.
We also need to make sure that move works as intended with respect to memory accounting
Member
|
We ignore the failiing tests for today because this is independent of the PR, just to be able to move on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the velocypack part of the supervised buffer, which is a type of buffer used together with velocypack in query processing to account memory automatically instead of having to do it by hand in every function, so everything's centralized in one place. Yet, one must still avoid accounting for memory twice inside the code for now (to be changed)