DAO-74: client crash connecting wallet #1571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAO-74 add tests for GovernTokenFactory
add e2e tests for GovernTokenFactory in order to test if bulk items are assigned correctly. |
|
Leaving this PR untouched for a while. Multichain branch doesn't have this problem surprisingly. So after merging everything, if the problem persists, we get back to this again... |
|
close this PR as the decision not to use this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is just a workaround and there's a trade off, the workaround disables the focus on the domain field.
Potential fix:
See this issue from react-spring: Cannot read property 'push' of undefined pmndrs/react-spring#576
cannot render functions...I found the workaround while testing with
<Transaction> keysworkaround mentioned in the react-spring issue. After I converted this https://github.com/aragon/client/blob/master/src/components/AccountModule/AccountModulePopover.js#L106 to a string (currently, it's a function), the client no longer crashes but the account dialog closes after selecting a wallet. I noticed the focus moved back to the input field and I suspect it's related to the UI issue: Modal: Dropdown interactions trigger a close ui#813