Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add workflow to check Go versions of dependencies #5340

Merged

Conversation

DmitriyLewen
Copy link
Contributor

Description

Starting from Go 1.21, it checks the go line in all dependencies of go.mod, and determines the minimum Go version.
See #5323 (comment).

Before Go 1.22 is released - Create GitHub action to find dependencies that require Go 1.21 to avoid incorrect updates.

Test Runs:

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen marked this pull request as ready for review October 5, 2023 10:09
@DmitriyLewen DmitriyLewen requested a review from knqyf263 as a code owner October 5, 2023 10:09
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment that it is a workaround until oldstable will be Go 1.21? I don't think this problem will occur with oldstable: Go 1.21 and stable: 1.22.

@DmitriyLewen
Copy link
Contributor Author

Done

@knqyf263 knqyf263 added this pull request to the merge queue Oct 9, 2023
Merged via the queue into aquasecurity:main with commit 91841f5 Oct 9, 2023
@DmitriyLewen DmitriyLewen deleted the ci/add-check-to-go-version-of-deps branch November 28, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants