Skip to content

Commit

Permalink
Fix CircleCI example in README.md (#451)
Browse files Browse the repository at this point in the history
After trying to run trivy using CircleCI based on the sample configuration and failing, I want to suggest the following updates:

* `docker:18.09-git` no longer exists and causes workflow to fail, replaced with `stable-git` instead.
* added  `setup_remote_docker` or else the docker commands fail in the rest of the execution, as per https://circleci.com/docs/2.0/building-docker-images/#overview

Co-authored-by: Teppei Fukuda <[email protected]>
  • Loading branch information
asieira and knqyf263 authored Apr 1, 2020
1 parent 1bc02f9 commit e5ff5ec
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1207,9 +1207,10 @@ $ cat .circleci/config.yml
jobs:
build:
docker:
- image: docker:18.09-git
- image: docker:stable-git
steps:
- checkout
- setup_remote_docker
- run:
name: Build image
command: docker build -t trivy-ci-test:${CIRCLE_SHA1} .
Expand Down

0 comments on commit e5ff5ec

Please sign in to comment.