-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(checks): Rename repo to trivy-checks #109
Conversation
run: | | ||
tags=(latest ${{ env.RELEASE_VERSION}} ${{env.MINOR_VERSION }} ${{ env.MAJOR_VERSION }}) | ||
for tag in ${tags[@]}; do | ||
oras push ghcr.io/aquasecurity/trivy-policies:${tag} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping this hardcoded for trivy-policies bundle as we will also rename the repo (to trivy-checks) but want to keep the bundle for backwards compatibility.
@nikpivkin could you take a look? The PR itself is minor but please feel to point if if we've missed any other part of the repo (or elsewhere) that needs to be renamed. |
I've verified the generation of the checks bundle here https://github.com/aquasecurity/trivy-checks/pkgs/container/trivy-checks |
@@ -4,7 +4,7 @@ Use the most modern TLS/SSL policies available | |||
```hcl | |||
resource "aws_cloudfront_distribution" "good_example" { | |||
viewer_certificate { | |||
cloudfront_default_certificate = false | |||
cloudfront_default_certificate = aws_acm_certificate.example.arn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forgot to synchronize with the main branch.
@simar7 Trivy has successfully downloaded the new bundle. There is still some use of the term |
Yeah I thought to just leave it for now. |
@@ -1,15 +1,13 @@ | |||
|
|||
Using Customer managed keys provides comprehensive control over cryptographic keys, enabling management of policies, permissions, and rotation, thus enhancing security and compliance measures for sensitive data and systems. | |||
Cloudtrail logs should be encrypted at rest to secure the sensitive data. Cloudtrail logs record all activity that occurs in the the account through API calls and would be one of the first places to look when reacting to a breach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you synchronise this and other files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes: aquasecurity/trivy#5609