Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add kernel 6.8 and 6.10 in matrix images #4434

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

rscampos
Copy link
Collaborator

@rscampos rscampos commented Dec 16, 2024

1. Explain what the PR does

d452404 chore: add kernel 6.8 and 6.10 in matrix images

- Add kernel 6.8 and 6.10, both for x86_64 and aarch64;
- Both kernels are based on Ubuntu 24.04 LTS (codename Noble).

2. Explain how to test it

3. Other comments

@rscampos rscampos self-assigned this Dec 16, 2024
@geyslan
Copy link
Member

geyslan commented Dec 16, 2024

https://github.com/aquasecurity/tracee/actions/runs/12352508128/job/34469702343?pr=4434#step:4:33

To avoid installing all by hand again I suggest you pick the latest image, set package providers, upgrade packages (and system), and finally set the desired kernel.

@rscampos rscampos marked this pull request as draft December 16, 2024 13:20
@rscampos rscampos force-pushed the add_new_kernel_instance branch 15 times, most recently from 7e061df to 3c93c58 Compare December 16, 2024 21:24
@rscampos
Copy link
Collaborator Author

Hey @geyslan, thanks for the tip! It was a permission issue – now resolved. I decided to do a fresh install using the Ubuntu 24.04 image, and everything started working after that (kernel 6.8 and kernel 6.10 in this first phase).

@rscampos rscampos requested a review from geyslan December 17, 2024 10:35
@rscampos rscampos marked this pull request as ready for review December 17, 2024 10:35
@rscampos rscampos force-pushed the add_new_kernel_instance branch from 3c93c58 to 4fc4797 Compare December 17, 2024 10:39
@rscampos rscampos changed the title chore: add AMI in matrix images chore: add kernel 6.8 and 6.10 in matrix images Dec 17, 2024
Copy link
Member

@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rscampos rscampos force-pushed the add_new_kernel_instance branch 2 times, most recently from e01c6fb to bca0a38 Compare December 17, 2024 14:37
- Add kernel 6.8 and 6.10, both for x86_64 and aarch64;
- Both kernels are based on Ubuntu 24.04 LTS (codename Noble).
@rscampos rscampos force-pushed the add_new_kernel_instance branch from bca0a38 to d452404 Compare December 17, 2024 14:54
@rscampos
Copy link
Collaborator Author

@geyslan just added kernel 6.8 and 6.10 for arm64 :)

@geyslan
Copy link
Member

geyslan commented Dec 17, 2024

@geyslan just added kernel 6.8 and 6.10 for arm64 :)

Awesome, bring them in.

@rscampos
Copy link
Collaborator Author

/fast-forward

Copy link

Triggered from #4434 (comment) by @​rscampos.

Trying to fast forward main (84aca9d) to add_new_kernel_instance (d452404).

Target branch (main):

commit 84aca9d8b4ee652bf871ed264f61f4925b17ce1b (HEAD -> main, origin/main, origin/HEAD)
Author: Gregório G. <[email protected]>
Date:   Tue Dec 17 08:38:49 2024 -0300

    fix(ci): add runner type to release workflows (#4436)
    
    Set INSTANCE_TYPE=LARGE for release workflows as
    release demands a runner with higher specs.

Pull request (add_new_kernel_instance):

commit d4524045ed9cdc11ede9f148a1e1b064312b686d (pull_request/add_new_kernel_instance)
Author: Raphael Campos <[email protected]>
Date:   Tue Dec 17 04:37:55 2024 -0600

    chore: add kernel 6.8 and 6.10 in matrix images
    
    - Add kernel 6.8 and 6.10, both for x86_64 and aarch64;
    - Both kernels are based on Ubuntu 24.04 LTS (codename Noble).

Fast forwarding main (84aca9d) to add_new_kernel_instance (d452404).

$ git push origin d4524045ed9cdc11ede9f148a1e1b064312b686d:main
To https://github.com/aquasecurity/tracee.git
 ! [remote rejected]   d4524045ed9cdc11ede9f148a1e1b064312b686d -> main (refusing to allow a GitHub App to create or update workflow `.github/workflows/pr.yaml` without `workflows` permission)
error: failed to push some refs to 'https://github.com/aquasecurity/tracee.git'

@rscampos rscampos merged commit d5ef388 into aquasecurity:main Dec 17, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants