Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.22.5] Perf event writes metric #4420

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented Dec 9, 2024

1. Explain what the PR does

32721cf chore(performance): update tracee dashboard

commit: bae1532 (main), cherry-pick

09df099 chore: add perfbuf metric per event (METRICS=1)

Enabled only when built with METRICS=1.

BPFPerfEventSubmitAttemptsCount and BPFPerfEventSubmitFailuresCount
count the number of events processed by the eBPF programs and written to
or attempted to be written to the perf buffer.

It is incremented right after the attempt of writing the event to the
perf buffer, making it possible to measure if the that event was
successfully written to the perf buffer or not.

This metric can be used to monitor the performance of individual eBPF
events and to detect potential bottlenecks.

commit: 5a5c2e7 (main), backport

[backport]
  - changed countPerfEventSubmissions to use eventsState.

4311d33 chore(go.mod): bump api to latest 6968a8b

commit: 5fe36d1 (main), backport

[backport]
  - update go.mod and go.sum pointing to 6968a8b (v0.22.0)

2. Explain how to test it

3. Other comments

commit: 5fe36d1 (main), backport

[backport]
  - update go.mod and go.sum pointing to 6968a8b (v0.22.0)
Enabled only when built with METRICS=1.

BPFPerfEventSubmitAttemptsCount and BPFPerfEventSubmitFailuresCount
count the number of events processed by the eBPF programs and written to
or attempted to be written to the perf buffer.

It is incremented right after the attempt of writing the event to the
perf buffer, making it possible to measure if the that event was
successfully written to the perf buffer or not.

This metric can be used to monitor the performance of individual eBPF
events and to detect potential bottlenecks.

commit: 5a5c2e7 (main), backport

[backport]
  - changed countPerfEventSubmissions to use eventsState.
@geyslan geyslan added cherry-pick Label for cherry-pick PRs backport Label for backport PRs labels Dec 9, 2024
@geyslan geyslan requested a review from rscampos December 9, 2024 13:53
@geyslan geyslan self-assigned this Dec 9, 2024
Copy link
Collaborator

@rscampos rscampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geyslan geyslan merged commit 7ec7907 into aquasecurity:v0.22.0 Dec 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants