Skip to content

Conversation

@gregnazario
Copy link
Collaborator

Description

Test Plan

Related Links

Checklist

  • Have you ran pnpm fmt?
  • Have you updated the CHANGELOG.md?

@gregnazario gregnazario requested a review from Copilot September 12, 2025 21:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes type issues and removes unnecessary type casts throughout the codebase to improve type safety. The changes focus on properly typing function parameters, return types, and removing unsafe as any casts.

  • Corrects type definitions for authentication functions to use MoveFunctionId instead of string
  • Updates transaction-related types to use more specific CommittedTransactionResponse type
  • Removes unsafe type casts in favor of proper type annotations

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/e2e/api/transaction.test.ts Removes unsafe as any casts when accessing transaction version property
src/types/types.ts Updates Block type to use CommittedTransactionResponse instead of generic TransactionResponse
src/transactions/authenticator/account.ts Changes functionInfo parameter type from string to MoveFunctionId and removes type cast
src/internal/transaction.ts Updates getTransactions return type and removes type casts in fillBlockTransactions
src/internal/abstraction.ts Updates authenticationFunction parameters to use MoveFunctionId type
src/client/core.ts Replaces as any cast with proper type annotation for indexer response
src/api/transaction.ts Updates getTransactions return type to CommittedTransactionResponse[]
src/api/account/abstraction.ts Updates authenticationFunction parameters to use MoveFunctionId type
src/api/account.ts Adds generic type parameter to view function call and removes type cast
src/account/MultiKeyAccount.ts Removes unnecessary type casts for keyless signers filter
src/account/DerivableAbstractedAccount.ts Updates authenticationFunction parameter type to MoveFunctionId
src/account/AbstractedAccount.ts Updates authenticationFunction property type to MoveFunctionId

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants