-
Notifications
You must be signed in to change notification settings - Fork 91
Refactor token v2 models #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #704 +/- ##
=======================================
+ Coverage 50.0% 50.5% +0.5%
=======================================
Files 251 239 -12
Lines 28335 27984 -351
=======================================
- Hits 14181 14156 -25
+ Misses 14154 13828 -326 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yuunlimm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
| } | ||
| } | ||
|
|
||
| impl GetTimeStamp for ParquetCurrentTokenRoyaltyV1 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: when you migrate, this can be removed
| self.token_data_id.cmp(&other.token_data_id) | ||
| } | ||
| } | ||
| impl PartialOrd for PostgresCurrentTokenRoyaltyV1 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: extra space

commonfileTesting
Run tests