Add mobile footer to the splash template #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Greg Nazario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Astro's splash template doesn't draw Sidebar. In Starlight
Sidebarcomponent is responsible for rendering language/theme selects, social buttons and sidebar navigation itself. It does mean that when you use splash template it misses all of those features. There is even relevant issues in their GH.Starlight has overriding mechanism for their components, but the problem is sidebar rendering is tightly coupled with the
Pagecomponent, which they don't allow to override. We could patch their components, but I believe with their overrinding mechanism it will lead to a mess.The simplest solution we can do here is just to render
MobileMenuFootercomponent in thesplashtemplate.