-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: multipart file uploads #51
base: main
Are you sure you want to change the base?
Conversation
Appwrite/Client.cs
Outdated
{ "x-sdk-name", ".NET" }, | ||
{ "x-sdk-platform", "server" }, | ||
{ "x-sdk-language", "dotnet" }, | ||
{ "x-sdk-version", "0.10.0"}, | ||
{ "X-Appwrite-Response-Format", "1.6.0" } | ||
{ "x-sdk-version", "0.10.1"}, { "X-Appwrite-Response-Format", "1.6.0" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want it in single line?
Appwrite/Services/Functions.cs
Outdated
@@ -609,7 +609,7 @@ static Models.ExecutionList Convert(Dictionary<string, object> it) => | |||
/// function execution process will start asynchronously. | |||
/// </para> | |||
/// </summary> | |||
public Task<Models.Execution> CreateExecution(string functionId, string? body = null, bool? xasync = null, string? xpath = null, Appwrite.Enums.ExecutionMethod? method = null, object? headers = null, string? scheduledAt = null) | |||
public Task<Models.Execution> CreateExecution(string functionId, payload? body = null, bool? xasync = null, string? xpath = null, Appwrite.Enums.ExecutionMethod? method = null, object? headers = null, string? scheduledAt = null, Action<UploadProgress>? onProgress = null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that supposed to use payload
? if so should it be uppercase?
@@ -12,7 +12,7 @@ Functions functions = new Functions(client); | |||
|
|||
Execution result = await functions.CreateExecution( | |||
functionId: "<FUNCTION_ID>", | |||
body: "<BODY>", // optional | |||
body: , // optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're missing example here
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)