Skip to content

fix(publish): surface osslsigncode output when verify fails #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChiragAgg5k merged 1 commit into from
May 11, 2026
+11 −8
Merged

fix(publish): surface osslsigncode output when verify fails #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,23 +94,26 @@ jobs:

- name: Verify Windows signatures
run: |
set -euo pipefail
set -uo pipefail

verify_signature() {
local file="$1"
local output

local output rc
output="$(osslsigncode verify -in "$file" 2>&1)"
rc=$?
echo "--- $file (osslsigncode exit $rc) ---"
echo "$output"

if ! grep -Fq "Succeeded" <<< "$output"; then
echo "$file signature verification failed"
exit 1
if [ "$rc" -ne 0 ] || ! grep -Fq "Succeeded" <<< "$output"; then
echo "::error::$file signature verification failed"
return 1
fi
}

verify_signature build/appwrite-cli-win-x64.exe
verify_signature build/appwrite-cli-win-arm64.exe
final=0
verify_signature build/appwrite-cli-win-x64.exe || final=1
verify_signature build/appwrite-cli-win-arm64.exe || final=1
exit "$final"

- name: Setup Node.js
uses: actions/setup-node@v6
Expand Down