Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cancel shown on failed builds #1583

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

ItzNotABug
Copy link
Member

What does this PR do?

This PR fixes the issue where if the deployment has failed, the logs area would still show Cancel deployment button which doesn't make sense.

Test Plan

Manual.

fixed-logs-area

Related PRs and Issues

N/A.

Have you read the Contributing Guidelines on issues?

Yes.

@ItzNotABug ItzNotABug requested a review from ernstmul December 30, 2024 11:30
@ItzNotABug ItzNotABug self-assigned this Dec 31, 2024
@ItzNotABug ItzNotABug merged commit 93cece9 into feat-pink-v2 Jan 2, 2025
0 of 2 checks passed
@ItzNotABug ItzNotABug deleted the fix-hide-cancel-deployment branch January 2, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants