This repository has been archived by the owner on Jun 25, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 189
Encoding and ToolbarActions improvement #93
Open
LJaraCastillo
wants to merge
9
commits into
apptreesoftware:master
Choose a base branch
from
LJaraCastillo:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LJaraCastillo
commented
Jul 26, 2018
- Added methods to add/edit/remove/change visibility of ToolbarActions
- Added utility methods to encode and decode lists of Location
Flutter * Support for encoded path for polyline and polygon. * Added method for encode and decode paths. Android * Support for encoded path for polyline and polygon. * Added maps-utils dependency for Android. This library has the functions to encode and decode the path. iOS * Incomplete changes regarding the path encoding.
* Added getter for PathData to make it easy to get the content from the child classes (EncodedPath and PathPoints).
* Added add/edit/remove behavior for ToolbarAction. * Added method to change visibility of ToolbarAction.
Android & Flutter * Removed the direct usage of encoded points in polylines and polygons due to complex usage in Dart code. (too much type casting) * Encode and Decode methods in MapView remains as it is. iOS * Incomplete changes regarding the path encoding. * Incomplete changes regarding ToolbarActions.
Flutter * Updated version of uri package from ^0.11.1 to ^0.11.3 * dev_dependencies commented in example/pubspec.yaml due to error while compiling in last version of Flutter. iOS * Partial changes applied regarding encoding. Testing needed. * Partial changes applied regaring toolbar actions. ViewControllers left. Testing needed.
iOS * Toolbar Actions Methods Added and tested. * Encode & decode methods added and tested.
Fix previous commit
For those who need a decoded polyline right now:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.