Switch extension to TypedData API #1359
Merged
+88
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Data API has been deprecated for a while (see [Ruby's #19998][rb]) and as of Ruby 3.4.0, its usage emits deprecation warnings at build time. Switch the extension to use the TypedData API. The following sources were used as reference: - Ruby's `extension.rdoc`: https://github.com/ruby/ruby/blob/96db72ce38b27799dd8e80ca00696e41234db6ba/doc/extension.rdoc#encapsulate-c-data-into-a-ruby-object - Peter Zhu's "A Rubyist's Walk Along the C-side": https://blog.peterzhu.ca/ruby-c-ext-part-7/ - The Definitive Guide to Ruby's C API: http://silverhammermba.github.io/emberb/c/#data Fixes #1341. [rb]: https://bugs.ruby-lang.org/issues/19998
unflxw
requested review from
thijsc,
jeffkreeftmeijer,
tombruijn and
luismiramirez
|
Hi @unflxw, We've found some issues with your Pull Request.
|
|
C is scary and I have no idea what I'm doing, so I would really appreciate any feedback and a careful review. I have linked to the sources that aided me in translating the existing code from the Data API to the TypedData API. |
luismiramirez
approved these changes
Dec 24, 2024
This comment has been minimized.
This comment has been minimized.
7 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tombruijn
approved these changes
Jan 6, 2025
This is a message from the daily scheduled checks. |
unflxw
added a commit
that referenced
this pull request
Jan 7, 2025
Add a changeset for switching the extension to the TypedData API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Data API has been deprecated for a while (see Ruby's #19998) and as of Ruby 3.4.0, its usage emits deprecation warnings at build time.
Switch the extension to use the TypedData API.
The following sources were used as reference:
extension.rdoc: https://github.com/ruby/ruby/blob/96db72ce38b27799dd8e80ca00696e41234db6ba/doc/extension.rdoc#encapsulate-c-data-into-a-ruby-objectFixes #1341.