Skip to content

Conversation

@mororo250
Copy link
Contributor

Draft of sun position implementation.

@mororo250 mororo250 force-pushed the sun_position_algorithm branch from 9701d54 to 7daae39 Compare June 4, 2020 07:44
@mororo250 mororo250 force-pushed the sun_position_algorithm branch from 8414922 to ad8b591 Compare June 17, 2020 01:25
Copy link
Member

@dictoon dictoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very partial and superficial first review!

@mororo250 mororo250 force-pushed the sun_position_algorithm branch from ad8b591 to 1aaa93c Compare June 30, 2020 16:04
@mororo250 mororo250 marked this pull request as ready for review June 30, 2020 16:05
@dictoon
Copy link
Member

dictoon commented Jan 30, 2021

Hi,

@LZaw and I had another look at this PR. We feel that a few things need to be done in order for it to be merged.

In particular, the SunPositioner class presents itself as an appleseed entity (i.e. it inherits from renderer::Entity, etc.) but it doesn't really make sense.

Here is what we suggest:

  1. Don't make SunPositioner inherit from Entity
  2. Don't tag the class with APPLESEED_DLLSYMBOL
  3. Remove the constructor, pass arguments natively
  4. Remove the release() method
  5. Remove the private implementation
  6. Remove SunPositionerFactory

Essentially turns the class into a very plain C++ one, and expose it to Python like you're doing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants