Add sun disc. #2866
Open
Add sun disc. #2866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mororo250
force-pushed
the
Sun_disc
branch
8 times, most recently
from
e9c9782 to
26a9527
Compare
mororo250
force-pushed
the
Sun_disc
branch
5 times, most recently
from
331e133 to
046aa51
Compare
dictoon
requested changes
Jun 30, 2020
Member
dictoon
left a comment
dictoon
left a comment
There was a problem hiding this comment.
Thanks for your work!
This PR is problematic on many aspects. It will need to be deeply reworked before we can consider merging it.
Let's discuss on Discord!
mororo250
force-pushed
the
Sun_disc
branch
4 times, most recently
from
f9000f7 to
abfbae0
Compare
dictoon
reviewed
Jul 7, 2020
src/appleseed/renderer/modeling/environmentedf/hosekenvironmentedf.cpp
Outdated
Show resolved
Hide resolved
mororo250
force-pushed
the
Sun_disc
branch
2 times, most recently
from
74b9f3d to
5035b89
Compare
mororo250
force-pushed
the
Sun_disc
branch
2 times, most recently
from
e77aa69 to
76d1aa6
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft because #2811 is still open.