Fix memory leak in array binding for collections #72
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
The bindArray function was allocating a cass_collection via cass_collection_new
but never freeing it, causing a memory leak every time an array was bound to a
prepared statement.
Modifications:
Added defer { cass_collection_free(collection) } immediately after collection
allocation to ensure proper cleanup.
Result:
Collections are now properly freed after use, eliminating the memory leak in
array binding operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
bindArrayfunction was allocating acass_collectionviacass_collection_newbut never freeing it, causing a memory leak every time an array was bound to a prepared statement.Modifications
Added
defer { cass_collection_free(collection) }immediately after collection allocation to ensure proper cleanup.Result
Collections are now properly freed after use, eliminating the memory leak in array binding operations.