Fix all Github action soundness checks#346
Merged
FranzBusch merged 7 commits intoapple:mainfrom Mar 28, 2025
Merged
Conversation
glbrntt
reviewed
Mar 28, 2025
Contributor
|
FWIW: I think it'd make sense to rebase rather than squash here so that the formatting is kept as a separate commit so you can then ignore it from blames etc. |
phausler
reviewed
Mar 28, 2025
Member
phausler
left a comment
phausler
left a comment
There was a problem hiding this comment.
Personally I'd rather 2-sp indent since it matches the other sister packages, but as long as the files themselves are consistent it doesn't really matter to me 100%.
Member
|
why where the docker files removed? did they not work? (I don't remember who committed those) |
FranzBusch
force-pushed
the
fb-soundness-checks
branch
from
2f38944 to
43cf7e3
Compare
FranzBusch
force-pushed
the
fb-soundness-checks
branch
from
43cf7e3 to
a8ac2df
Compare
Member
Author
I added them previously because we wanted the old SwiftCI to use them. With GitHub Actions we no longer need them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We want to turn on GitHub Actions for this repository in #344. That PR has currently a few failing soundness checks.
Modifications
This PR fixes all of the soundness issues.
Result
Ready for GitHub Actions