Skip to content

Conversation

@solventak
Copy link

@solventak solventak commented Nov 13, 2025

Closes #758

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Motivation and Context

In order to speed up control in the command line, partial ID matches are now supported for commands that take in IDs as an argument.

Testing

  • Tested locally
  • Added/updated tests
  • Added/updated docs

@solventak solventak marked this pull request as draft November 13, 2025 23:06
@solventak
Copy link
Author

Right now just containers are supported for multi-id argument commands:

container kill
container inspect
container delete
container stop

but I wanted to get some feedback before working on the rest of the commands (there's a lot of them)!

@dcantah
Copy link
Member

dcantah commented Nov 14, 2025

I think this feature should be in the APIServer (ContainerService) and not client logic. The server knows the IDs/what exists and can just get sent the shortened prefix and try and match against it. That way all the logic is in one spot and not dup'd across all of the CLI commands that deal with IDs.

@solventak
Copy link
Author

Great point! Thanks for the callout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: support for partial containers IDs in the CLI

3 participants