fix: remove potential XSS vector in anchors widget#5482
Closed
MatrixNeoKozak wants to merge 1 commit into
Closed
Conversation
Member
|
Module options are set by developers. They are not user input. Therefore no vulnerability and no reason to restrict this. But if you think I'm mistaken please clarify how this can come from user input. |
Member
|
Also, if reporting a publicly undisclosed vulnerability please follow responsible disclosure by using github's advisory disclosure form: https://github.com/apostrophecms/apostrophe/security/advisories Or writing to security@apostrophecms.com. Thanks! |
Member
|
I missed that you are also escaping anchorId. However, anchorId is of Again, if you find and demonstrate a specific counterexample, please feel free to reopen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The anchors widget output method was directly interpolating
widget.anchorIdinto an HTML attribute without sanitization. If a user was able to control theanchorIdvalue, they could inject arbitrary HTML attributes, leading to a cross-site scripting (XSS) vulnerability. The fix escapes thewidget.anchorIdvalue before inserting it into thedivelement, ensuring it is treated as a plain string. Additionally, the attribute name is now checked against a whitelist to prevent injection into the attribute name itself.