Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom context menu to images #4853

Draft
wants to merge 1 commit into
base: pro-7053-document-versions-autopublish
Choose a base branch
from

Conversation

ETLaurent
Copy link
Contributor

@ETLaurent ETLaurent commented Jan 30, 2025

Summary

Make customOperations work for images.

It works, but as we can see, the whole logic is duplicated from modules/@apostrophecms/doc-type/ui/apos/logic/AposDocContextMenu.js.

TODO:

  • create ticket and try to make modules/@apostrophecms/image/ui/apos/components/AposMediaManagerEditor.vue use AposDocContextMenu.js in this PR
  • Make sure the "Export" custom context operation isn't there (in import-export module)

What are the specific steps to test this change?

For example:

  1. Run the website and log in as an admin
  2. Open a piece manager modal and select several pieces
  3. Click the "Archive" button on the top left of the manager and confirm that it should proceed
  4. Check that all pieces have been archived properly

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@ETLaurent ETLaurent added don't merge yet This PR is meant to be merged, but not right away don't merge This PR is not meant to be merged labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't merge yet This PR is meant to be merged, but not right away don't merge This PR is not meant to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant