Feature batch localization #4852
Open
+1,367
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRO-6856: batch localization UI and backend
myovchev
commented
Feb 3, 2025
| try { | ||
| await manager.localize(req, item, locale, { | ||
| update: !payload.relationship ? true : update, | ||
| batch: true |
There was a problem hiding this comment.
This flag is still not accounted anywhere. The idea is to be passed down to the localization event handlers.
myovchev
commented
Feb 3, 2025
| if (e.data?.parentNotLocalized) { | ||
| payload.detail = 'apostrophe:parentNotLocalized'; | ||
| } else { | ||
| payload.detail = e.data?.detail; |
There was a problem hiding this comment.
error.data.detail is a proposed standard in the context of the localization process. If the localization or any underlying event handling throws apos error and provides detail data property, it will be used in the UI error reporting.
myovchev
commented
Feb 3, 2025
| // human-readable message is a standard error payload property. | ||
| // For example `error.data.detail`. | ||
| if (e.data?.parentNotLocalized) { | ||
| payload.detail = 'apostrophe:parentNotLocalized'; |
There was a problem hiding this comment.
We may want to add detail: 'apostrophe:parentNotLocalized' where parentNotLocalized is calculated and assigned. This way we can remove the redundant checks here and in the i18n UI.
boutell
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The batch localization feature.
What are the specific steps to test this change?
See PRO-6856 and PRO-6965
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: