-
Notifications
You must be signed in to change notification settings - Fork 22
chore(deps): update ghcr.io/apollographql/router docker tag to v1.61.6 #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renovate
wants to merge
1
commit into
main
Choose a base branch
from
renovate/apollo-graphql-packages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
654d818
to
cb5dc37
Compare
cb5dc37
to
291fad6
Compare
43e2034
to
291fad6
Compare
9d72d3f
to
291fad6
Compare
0242dcd
to
291fad6
Compare
291fad6
to
d9efacf
Compare
b221ee3
to
dedf802
Compare
8ec335b
to
dedf802
Compare
dedf802
to
1c2d059
Compare
1c2d059
to
0f0cb1f
Compare
9b1995b
to
0f0cb1f
Compare
6474ca5
to
0f0cb1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v1.32.0
->v1.61.6
Release Notes
apollographql/router (ghcr.io/apollographql/router)
v1.61.6
Compare Source
🐛 Fixes
Fix JWT metrics discrepancy (PR #7258)
This fixes the
apollo.router.operations.authentication.jwt
counter metric to behave as documented: emitted for every request that uses JWT, with theauthentication.jwt.failed
attribute set to true or false for failed or successful authentication.Previously, it was only used for failed authentication.
The attribute-less and accidentally-differently-named
apollo.router.operations.jwt
counter was and is only emitted for successful authentication, but is deprecated now.By @SimonSapin in https://github.com/apollographql/router/pull/7258
Fix Redis connection leak (PR #7319)
The router performs a 'hot reload' whenever it detects a schema update. During this reload, it effectively instantiates a new internal router, warms it up (optional), redirects all traffic to this new router, and drops the old internal router.
This change fixes a bug in that drop process where the Redis connections are never told to terminate, even though the Redis client pool is dropped. This leads to an ever-increasing number of inactive Redis connections, which eats up memory.
It also adds a new up-down counter metric,
apollo.router.cache.redis.connections
, to track the number of open Redis connections. This metric includes akind
label to discriminate between different Redis connection pools, which mirrors thekind
label on other cache metrics (ieapollo.router.cache.hit.time
).By @carodewig in https://github.com/apollographql/router/pull/7319
Fix Parsing of Coprocessor GraphQL Responses (PR #7141)
Previously Router ignored
data: null
property inside GraphQL response returned by coprocessor.According to GraphQL Spectification:
That means if coprocessor returned valid execution error, for example:
Router violated above restriction from GraphQL Specification by returning following response to client:
This fix ensures full compliance with the GraphQL specification by preserving the complete structure of error responses from coprocessors.
Contributed by @IvanGoncharov in #7141
Avoid fractional decimals when generating
apollo.router.operations.batching.size
metrics for GraphQL request batch sizes (PR #7306)Correct the calculation of the
apollo.router.operations.batching.size
metric to reflect accurate batch sizes rather than occasionally returning fractional numbers.By @bnjjj in https://github.com/apollographql/router/pull/7306
📃 Configuration
Add configurable server header read timeout (PR #7262)
This change exposes the server's header read timeout as the
server.http.header_read_timeout
configuration option.By default, the
server.http.header_read_timeout
is set to previously hard-coded 10 seconds. A longer timeout can be configured using theserver.http.header_read_timeout
option.By @gwardwell in https://github.com/apollographql/router/pull/7262
🛠 Maintenance
Reject
@skip
/@include
on subscription root fields in validation (PR #7338)This implements a GraphQL spec RFC, rejecting subscriptions in validation that can be invalid during execution.
By @goto-bus-stop in https://github.com/apollographql/router/pull/7338
v1.61.5
Compare Source
🔍 Debuggability
Add compute job pool spans (PR #7236)
The compute job pool in the router is used to execute CPU intensive work outside of the main I/O worker threads, including GraphQL parsing, query planning, and introspection.
This PR adds spans to jobs that are on this pool to allow users to see when latency is introduced due to
resource contention within the compute job pool.
compute_job
:job.type
: (query_parsing
|query_planning
|introspection
)compute_job.execution
job.age
:P1
-P8
job.type
: (query_parsing
|query_planning
|introspection
)Jobs are executed highest priority (
P8
) first. Jobs that are low priority (P1
) age over time, eventually executingat highest priority. The age of a job is can be used to diagnose if a job was waiting in the queue due to other higher
priority jobs also in the queue.
By @bryncooke in https://github.com/apollographql/router/pull/7236
Add compute job pool metrics (PR #7184)
The compute job pool in the router is used to execute CPU intensive work outside of the main I/O worker threads, including GraphQL parsing, query planning, and introspection.
When this pool becomes saturated it is difficult for users to see why so that they can take action.
This change adds new metrics to help users understand how long jobs are waiting to be processed.
New metrics:
apollo.router.compute_jobs.queue_is_full
- A counter of requests rejected because the queue was full.apollo.router.compute_jobs.duration
- A histogram of time spent in the compute pipeline by the job, including the queue and query planning.job.type
: (query_planning
,query_parsing
,introspection
)job.outcome
: (executed_ok
,executed_error
,channel_error
,rejected_queue_full
,abandoned
)apollo.router.compute_jobs.queue.wait.duration
- A histogram of time spent in the compute queue by the job.job.type
: (query_planning
,query_parsing
,introspection
)apollo.router.compute_jobs.execution.duration
- A histogram of time spent to execute job (excludes time spent in the queue).job.type
: (query_planning
,query_parsing
,introspection
)apollo.router.compute_jobs.active_jobs
- A gauge of the number of compute jobs being processed in parallel.job.type
: (query_planning
,query_parsing
,introspection
)By @carodewig in https://github.com/apollographql/router/pull/7184
🐛 Fixes
Fix hanging requests when compute job queue is full (PR #7273)
The compute job pool in the router is used to execute CPU intensive work outside of the main I/O worker threads, including GraphQL parsing, query planning, and introspection. When the pool is busy, jobs enter a queue.
When the compute job queue was full, requests could hang until timeout. Now, the router immediately returns a
SERVICE_UNAVAILABLE
response to the user.By @BrynCooke in https://github.com/apollographql/router/pull/7273
Increase compute job pool queue size (PR #7205)
The compute job pool in the router is used to execute CPU intensive work outside of the main I/O worker threads, including GraphQL parsing, query planning, and introspection. When the pool is busy, jobs enter a queue.
We previously set this queue size to 20 (per thread). However, this may be too small on resource constrained environments.
This patch increases the queue size to 1,000 jobs per thread. For reference, in older router versions before the introduction of the compute job worker pool, the equivalent queue size was 1,000.
By @goto-bus-stop in https://github.com/apollographql/router/pull/7205
v1.61.4
Compare Source
🐛 Fixes
Entity-cache: handle multiple key directives (PR #7228)
This PR fixes a bug in entity caching introduced by the fix in https://github.com/apollographql/router/pull/6888 for cases where several
@key
directives with different fields were declared on a type as documented here.For example if you have this kind of entity in your schema:
By @duckki & @bnjjj in https://github.com/apollographql/router/pull/7228
v1.61.3
Compare Source
🐛 Fixes
Fix potential telemetry deadlock (PR #7142)
The
tracing_subscriber
crate usesRwLock
s to manage access to aSpan
'sExtensions
. Deadlocks are possible whenmultiple threads access this lock, including with reentrant locks:
This fix removes an opportunity for reentrant locking while extracting a Datadog identifier.
There is also a potential for deadlocks when the root and active spans'
Extensions
are acquired at the same time, ifmultiple threads are attempting to access those
Extensions
but in a different order. This fix removes a few caseswhere multiple spans'
Extensions
are acquired at the same time.By @carodewig in https://github.com/apollographql/router/pull/7142
Connection shutdown timeout (PR #7058)
When a connection is closed we call
graceful_shutdown
on hyper and then await for the connection to close.Hyper 0.x has various issues around shutdown that may result in us waiting for extended periods for the connection to eventually be closed.
This PR introduces a configurable timeout from the termination signal to actual termination, defaulted to 60 seconds. The connection is forcibly terminated after the timeout is reached.
To configure, set the option in router yaml. It accepts human time durations:
Note that even after connections have been terminated the router will still hang onto pipelines if
early_cancel
has not been configured to true. The router is trying to complete the request.Users can either set
early_cancel
totrue
AND/OR use traffic shaping timeouts:
By @BrynCooke in https://github.com/apollographql/router/pull/7058
Fix crash when an invalid query plan is generated (PR #7214)
When an invalid query plan is generated, the router could panic and crash.
This could happen if there are gaps in the GraphQL validation implementation.
Now, even if there are unresolved gaps, the router will handle it gracefully and reject the request.
By @goto-bus-stop in https://github.com/apollographql/router/pull/7214
Improve Error Message for Invalid JWT Header Values (PR #7121)
Enhanced parsing error messages for JWT Authorization header values now provide developers with clear, actionable feedback while ensuring that no sensitive data is exposed.
Examples of the updated error messages:
By @IvanGoncharov in https://github.com/apollographql/router/pull/7121
v1.61.2
Compare Source
🔒 Security
Certain query patterns may cause resource exhaustion
Corrects a set of denial-of-service (DOS) vulnerabilities that made it possible for an attacker to render router inoperable with certain simple query patterns due to uncontrolled resource consumption. All prior-released versions and configurations are vulnerable except those where
persisted_queries.enabled
,persisted_queries.safelist.enabled
, andpersisted_queries.safelist.require_id
are alltrue
.See the associated GitHub Advisories GHSA-3j43-9v8v-cp3f, GHSA-84m6-5m72-45fp, GHSA-75m2-jhh5-j5g2, and GHSA-94hh-jmq8-2fgp, and the
apollo-compiler
GitHub Advisory GHSA-7mpv-9xg6-5r79 for more information.By @sachindshinde and @goto-bus-stop.
v1.61.1
Compare Source
🐛 Fixes
Use correct default values on omitted OTLP endpoints (PR #6931)
Previously, when the configuration didn't specify an OTLP endpoint, the Router would always default to
http://localhost:4318
. However, port4318
is the correct default only for the HTTP protocol, while port4317
should be used for gRPC.Additionally, all other telemetry defaults in the Router configuration consistently use
127.0.0.1
as the hostname rather thanlocalhost
.With this change, the Router now uses:
http://127.0.0.1:4317
as the default for gRPC protocolhttp://127.0.0.1:4318
as the default for HTTP protocolThis ensures protocol-appropriate port defaults and consistent hostname usage across all telemetry configurations.
By @IvanGoncharov in https://github.com/apollographql/router/pull/6931
Separate entity keys and representation variables in entity cache key (Issue #6673)
This fix separates the entity keys and representation variable values in the cache key, to avoid issues with
@requires
for example.By @bnjjj in https://github.com/apollographql/router/pull/6888
🔒 Security
Add
batching.maximum_size
configuration option to limit maximum client batch size (PR #7005)Add an optional
maximum_size
parameter to the batching configuration.maximum_size
queries in the client batch.If the number of queries provided exceeds the maximum batch size, the entire batch fails with error code 422 (
Unprocessable Content
). For example:By @carodewig in https://github.com/apollographql/router/pull/7005
🔍 Debuggability
Add
apollo.router.pipelines
metrics (PR #6967)When the router reloads, either via schema change or config change, a new request pipeline is created.
Existing request pipelines are closed once their requests finish. However, this may not happen if there are ongoing long requests that do not finish, such as Subscriptions.
To enable debugging when request pipelines are being kept around, a new gauge metric has been added:
apollo.router.pipelines
- The number of request pipelines active in the routerschema.id
- The Apollo Studio schema hash associated with the pipeline.launch.id
- The Apollo Studio launch id associated with the pipeline (optional).config.hash
- The hash of the configurationBy @BrynCooke in https://github.com/apollographql/router/pull/6967
Add
apollo.router.open_connections
metric (PR #7023)To help users to diagnose when connections are keeping pipelines hanging around, the following metric has been added:
apollo.router.open_connections
- The number of request pipelines active in the routerschema.id
- The Apollo Studio schema hash associated with the pipeline.launch.id
- The Apollo Studio launch id associated with the pipeline (optional).config.hash
- The hash of the configuration.server.address
- The address that the router is listening on.server.port
- The port that the router is listening on if not a unix socket.state
- Eitheractive
orterminating
.You can use this metric to monitor when connections are open via long running requests or keepalive messages.
By @BrynCooke in https://github.com/apollographql/router/pull/7009
v1.61.0
: - LTSCompare Source
To find out more about our maintenance and support policy, please refer to our docs
🚀 Features
Query planner dry-run option (PR #6656)
This PR adds a new
dry-run
option to theApollo-Expose-Query-Plan
header value that emits the query plans back to Studio for visualizations. This new value will only emit the query plan, and abort execution. This can be helpful for tools likerover
, where query plan generation is needed but not full runtime, or for potentially prewarming query plan caches out of band.By @aaronArinder and @lennyburdette in https://github.com/apollographql/router/pull/6656.
Enable Remote Proxy Downloads
This enables users without direct download access to specify a remote proxy mirror location for the github download of
the Apollo Router releases.
By @LongLiveCHIEF in https://github.com/apollographql/router/pull/6667
🐛 Fixes
Header propagation rules passthrough (PR #6690)
Header propagation contains logic to prevent headers from being propagated more than once. This was broken
in https://github.com/apollographql/router/pull/6281 which always considered a header propagated regardless if a rule
actually matched.
This PR alters the logic so that a header is marked as fixed only when it's populated.
The following will now work again:
Note that defaulting a header WILL populate it, so make sure to include your defaults last in your propagation
rules.
Instead, make sure that your headers are defaulted last:
By @BrynCooke in https://github.com/apollographql/router/pull/6690
Entity cache: fix directive conflicts in cache-control header (Issue #6441)
Unnecessary cache-control directives are created in cache-control header. The router will now filter out unnecessary values from the
cache-control
header when the request resolves. So if there'smax-age=10, no-cache, must-revalidate, no-store
, the expected value for the cache-control header would simply beno-store
. Please see the MDN docs for justification of this reasoning: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control#preventing_storingBy @bnjjj in https://github.com/apollographql/router/pull/6543
Query Planning: fix
__typename
selections in sibling typename optimizationThe query planner uses an optimization technique called "sibling typename", which attaches
__typename
selections to their sibling selections so the planner won't need to plan them separately.Previously, when there were multiple identical selections and one of them has a
__typename
attached, the query planner could pick the one without the attachment, effectively losing a__typename
selection.Now, the query planner favors the one with a
__typename
attached without losing the__typename
selection.By @duckki in https://github.com/apollographql/router/pull/6824
📃 Configuration
Promote
experimental_otlp_tracing_sampler
config to stable (PR #6070)The router's otlp tracing sampler feature that was previously experimental is now generally available.
If you used its experimental configuration, you should migrate to the new configuration option:
telemetry.apollo.experimental_otlp_tracing_sampler
is nowtelemetry.apollo.otlp_tracing_sampler
The experimental configuration option is now deprecated. It remains functional but will log warnings.
By @garypen in https://github.com/apollographql/router/pull/6070
Promote
experimental_local_manifess
config for persisted queries to stableThe
experimental_local_manifests
PQ configuration option is being promoted to stable. This change updates the configuration option name and any references to it, as well as the related documentation. Theexperimental_
usage remains valid as an alias for existing usages.By @trevor-scheer in https://github.com/apollographql/router/pull/6564
🛠 Maintenance
Reduce demand control allocations on start/reload (PR #6754)
When demand control is enabled, the router now preallocates capacity for demand control's processed schema and shrinks to fit after processing. When it's disabled, the router skips the type processing entirely to minimize startup impact.
By @tninesling in https://github.com/apollographql/router/pull/6754
v1.60.1
Compare Source
🐛 Fixes
Header propagation rules passthrough (PR #6690)
Header propagation contains logic to prevent headers from being propagated more than once. This was broken
in https://github.com/apollographql/router/pull/6281 which always considered a header propagated regardless if a rule
actually matched.
This PR alters the logic so that only when a header is populated then the header is marked as fixed.
The following will now work again:
Note that defaulting a head WILL populate a header, so make sure to include your defaults last in your propagation
rules.
Instead, make sure that your headers are defaulted last:
By @BrynCooke in https://github.com/apollographql/router/pull/6690
Entity cache: fix directive conflicts in cache-control header (Issue #6441)
Unnecessary cache-control directives are created in cache-control header. The router will now filter out unnecessary values from the
cache-control
header when the request resolves. So if there'smax-age=10, no-cache, must-revalidate, no-store
, the expected value for the cache-control header would simply beno-store
. Please see the MDN docs for justification of this reasoning: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control#preventing_storingBy @bnjjj in https://github.com/apollographql/router/pull/6543
Resolve regressions in fragment compression for certain operations (PR #6651)
In v1.58.0 we introduced a new compression strategy for subgraph GraphQL operations to replace an older, more complicated algorithm.
While we were able to validate improvements for a majority of cases, some regressions still surfaced. To address this, we are extending it to compress more operations with the following outcomes:
By @dariuszkuc in https://github.com/apollographql/router/pull/6651
v1.60.0
Compare Source
🚀 Features
Improve BatchProcessor observability (Issue #6558)
A new metric has been introduced to allow observation of how many spans are being dropped by an telemetry batch processor.
apollo.router.telemetry.batch_processor.errors
- The number of errors encountered by exporter batch processors.name
: One ofapollo-tracing
,datadog-tracing
,jaeger-collector
,otlp-tracing
,zipkin-tracing
.error
= One ofchannel closed
,channel full
.By observing the number of spans dropped it is possible to estimate what batch processor settings will work for you.
In addition, the log message for dropped spans will now indicate which batch processor is affected.
By @bryncooke in https://github.com/apollographql/router/pull/6558
🐛 Fixes
Improve performance of query hashing by using a precomputed schema hash (PR #6622)
The router now uses a simpler and faster query hashing algorithm with more predictable CPU and memory usage. This improvement is enabled by using a precomputed hash of the entire schema, rather than computing and hashing the subset of types and fields used by each query.
For more details on why these design decisions were made, please see the PR description
By @IvanGoncharov in https://github.com/apollographql/router/pull/6622
Truncate invalid error paths (PR #6359)
This fix addresses an issue where the router was silently dropping subgraph errors that included invalid paths.
According to the GraphQL Specification an error path must point to a response field:
The router now truncates the path to the nearest valid field path if a subgraph error includes a path that can't be matched to a response field,
By @IvanGoncharov in https://github.com/apollographql/router/pull/6359
Eagerly init subgraph operation for subscription primary nodes (PR #6509)
When subgraph operations are deserialized, typically from a query plan cache, they are not automatically parsed into a full document. Instead, each node needs to initialize its operation(s) prior to execution. With this change, the primary node inside SubscriptionNode is initialized in the same way as other nodes in the plan.
By @tninesling in https://github.com/apollographql/router/pull/6509
Fix increased memory usage in
sysinfo
since Router 1.59.0 (PR #6634)In version 1.59.0, Apollo Router started using the
sysinfo
crate to gather metrics about available CPUs and RAM. By default, that crate usesrayon
internally to parallelize its handling of system processes. In turn, rayon creates a pool of long-lived threads.In a particular benchmark on a 32-core Linux server, this caused resident memory use to increase by about 150 MB. This is likely a combination of stack space (which only gets freed when the thread terminates) and per-thread space reserved by the heap allocator to reduce cross-thread synchronization cost.
This regression is now fixed by:
sysinfo
’s use ofrayon
, so the thread pool is not created and system processes information is gathered in a sequential loop.sysinfo
not gather that information in the first place since Router does not use it.By @SimonSapin in https://github.com/apollographql/router/pull/6634
Optimize demand control lookup (PR #6450)
The performance of demand control in the router has been optimized.
Previously, demand control could reduce router throughput due to its extra processing required for scoring.
This fix improves performance by shifting more data to be computed at plugin initialization and consolidating lookup queries:
By @tninesling in https://github.com/apollographql/router/pull/6450
Fix missing Content-Length header in subgraph requests (Issue #6503)
A change in
1.59.0
caused the Router to send requests to subgraphs without aContent-Length
header, which would cause issues with some GraphQL servers that depend on that header.This solves the underlying bug and reintroduces the
Content-Length
header.By @nmoutschen in https://github.com/apollographql/router/pull/6538
🛠 Maintenance
Remove the legacy query planner (PR #6418)
The legacy query planner has been removed in this release. In the previous release, router v1.58, it was no longer used by default but was still available through the
experimental_query_planner_mode
configuration key. That key is now removed.Also removed are configuration keys which were only relevant to the legacy planner:
supergraph.query_planning.experimental_parallelism
: the new planner can always use available parallelism.supergraph.experimental_reuse_query_fragments
: this experimental algorithm that attempted toreuse fragments from the original operation while forming subgraph requests is no longer present. Instead, by default new fragment definitions are generated based on the shape of the subgraph operation.
By @SimonSapin in https://github.com/apollographql/router/pull/6418
Migrate various metrics to OTel instruments (PR #6476, PR #6356, PR #6539)
Various metrics using our legacy mechanism based on the
tracing
crate are migrated to OTel instruments.By @goto-bus-stop in https://github.com/apollographql/router/pull/6476, https://github.com/apollographql/router/pull/6356, https://github.com/apollographql/router/pull/6539
📚 Documentation
Add instrumentation configuration examples (PR #6487)
The docs for router telemetry have new example configurations for common use cases for selectors and condition.
By @shorgi in https://github.com/apollographql/router/pull/6487
🧪 Experimental
Remove experimental_retry option (PR #6338)
The
experimental_retry
option has been removed due to its limited use and functionality during its experimental phase.By @bnjjj in https://github.com/apollographql/router/pull/6338
v1.59.2
Compare Source
🐛 Fixes
Improve performance of query hashing by using a precomputed schema hash (PR #6622)
The router now uses a simpler and faster query hashing algorithm with more predictable CPU and memory usage. This improvement is enabled by using a precomputed hash of the entire schema, rather than computing and hashing the subset of types and fields used by each query.
For more details on why these design decisions were made, please see the PR description
By @IvanGoncharov in https://github.com/apollographql/router/pull/6622
Fix increased memory usage in
sysinfo
since Router 1.59.0 (PR #6634)In version 1.59.0, Apollo Router started using the
sysinfo
crate to gather metrics about available CPUs and RAM. By default, that crate usesrayon
internally to parallelize its handling of system processes. In turn, rayon creates a pool of long-lived threads.In a particular benchmark on a 32-core Linux server, this caused resident memory use to increase by about 150 MB. This is likely a combination of stack space (which only gets freed when the thread terminates) and per-thread space reserved by the heap allocator to reduce cross-thread synchronization cost.
This regression is now fixed by:
sysinfo
’s use ofrayon
, so the thread pool is not created and system processes information is gathered in a sequential loop.sysinfo
not gather that information in the first place since Router does not use it.By @SimonSapin in https://github.com/apollographql/router/pull/6634
v1.59.1
Compare Source
🐛 Fixes
Fix transmitted header value for Datadog priority sampling resolution (PR #6017)
The router now transmits correct values of
x-datadog-sampling-priority
to downstream services.Previously, an
x-datadog-sampling-priority
of-1
was incorrectly converted to0
for downstream requests, and2
was incorrectly converted to1
. When propagating to downstream services, this resulted in values ofUSER_REJECT
being incorrectly transmitted asAUTO_REJECT
.Enable accurate Datadog APM metrics (PR #6017)
The router supports a new preview feature, the
preview_datadog_agent_sampling
option, to enable sending all spans to the Datadog Agent so APM metrics and views are accurate.Previously, the sampler option in
telemetry.exporters.tracing.common.sampler
wasn't Datadog-aware. To get accurate Datadog APM metrics, all spans must be sent to the Datadog Agent with apsr
orsampling.priority
attribute set appropriately to record the sampling decision.The
preview_datadog_agent_sampling
option enables accurate Datadog APM metrics. It should be used when exporting to the Datadog Agent, via OTLP or Datadog-native.Using these options can decrease your Datadog bill, because you will be sending only a percentage of spans from the Datadog Agent to Datadog.
Learn more by reading the updated Datadog tracing documentation for more information on configuration options and their implications.
Fix non-parent sampling (PR #6481)
When the user specifies a non-parent sampler the router should ignore the information from upstream and use its own sampling rate.
The following configuration would not work correctly:
All spans are being sampled.
This is now fixed and the router will correctly ignore any upstream sampling decision.
By @BrynCooke in https://github.com/apollographql/router/pull/6481
v1.59.0
Compare Source
🚀 Features
General availability of native query planner
The router's native, Rust-based, query planner is now generally available and enabled by default.
The native query planner achieves better performance for a variety of graphs. In our tests, we observe:
apollo.router.query_planning.plan.duration
)The native query planner supports Federation v2 supergraphs. If you are using Federation v1 today, see our migration guide on how to update your composition build step. Subgraph changes are typically not needed.
The legacy, JavaScript, query planner is deprecated in this release, but you can still switch
back to it if you are still using Federation v1 supergraph:
By @sachindshinde, @goto-bus-stop, @duckki, @TylerBloom, @SimonSapin, @dariuszkuc, @lrlna, @clenfest, and @o0Ignition0o.
Ability to skip persisted query list safelisting enforcement via plugin (PR #6403)
If safelisting is enabled, a
router_service
plugin can skip enforcement of the safelist (including therequire_id
check) by adding the keyapollo_persisted_queries::safelist::skip_enforcement
with valuetrue
to the request context.In cases where an operation would have been denied but is allowed due to the context key existing, the attribute
persisted_queries.safelist.enforcement_skipped
is set on theapollo.router.operations.persisted_queries
metric with valuetrue
.By @glasser in https://github.com/apollographql/router/pull/6403
Add fleet awareness plugin (PR #6151)
A new
fleet_awareness
plugin has been added that reports telemetry to Apollo about the configuration and deployment of the router.The reported telemetry include CPU and memory usage, CPU frequency, and other deployment characteristics such as operating system and cloud provider. For more details, along with a full list of data captured and how to opt out, go to our
data privacy policy.
By @jonathanrainer, @nmoutschen, @loshz in https://github.com/apollographql/router/pull/6151
Add fleet awareness schema metric (PR #6283)
The router now supports the
apollo.router.instance.schema
metric for itsfleet_detector
plugin. It has two attributes:schema_hash
andlaunch_id
.By @loshz and @nmoutschen in https://github.com/apollographql/router/pull/6283
Support client name for persisted query lists (PR #6198)
The persisted query manifest fetched from Apollo Uplink can now contain a
clientName
field in each operation. Two operations with the sameid
but differentclientName
are considered to be distinct operations, and they may have distinct bodies.The router resolves the client name by taking the first from the following that exists:
apollo_persisted_queries::client_name
context key that may be set by arouter_service
plugintelemetry.apollo.client_name_header
, which defaults toapollographql-client-name
If a client name can be resolved for a request, the router first tries to find a persisted query with the specified ID and the resolved client name.
If there is no operation with that ID and client name, or if a client name cannot be resolved, the router tries to find a persisted query with the specified ID and no client name specified. This means that existing PQ lists that don't contain client names will continue to work.
To learn more, go to persisted queries docs.
By @glasser in https://github.com/apollographql/router/pull/6198
🐛 Fixes
Fix coprocessor empty body object panic (PR #6398)
Previously, the router would panic if a coprocessor responds with an empty body object at the supergraph stage:
This has been fixed in this release.
By @BrynCooke in https://github.com/apollographql/router/pull/6398
Ensure cost directives are picked up when not explicitly imported (PR #6328)
With the recent composition changes, importing
@cost
results in a supergraph schema with the cost specification import at the top. The@cost
directive itself is not explicitly imported, as it's expected to be available as the default export from the cost link. In contrast, uses of@listSize
to translate to an explicit import in the supergraph.Old SDL link
New SDL link
Instead of using the directive names from the import list in the link, the directive names now come from
SpecDefinition::directive_name_in_schema
, which is equivalent to the change we made on the composition side.By @tninesling in https://github.com/apollographql/router/pull/6328
Fix query hashing algorithm (PR #6205)
The router includes a schema-aware query hashing algorithm designed to return the same hash across schema updates if the query remains unaffected. This update enhances the algorithm by addressing various corner cases to improve its reliability and consistency.
By @Geal in https://github.com/apollographql/router/pull/6205
Fix typo in persisted query metric attribute (PR #6332)
The
apollo.router.operations.persisted_queries
metric reports an attribute when a persisted query was not found.Previously, the attribute name was
persisted_quieries.not_found
, with onei
too many. Now it'spersisted_queries.not_found
.By @goto-bus-stop in https://github.com/apollographql/router/pull/6332
Fix telemetry instrumentation using supergraph query selector (PR #6324)
Previously, router telemetry instrumentation that used query selectors could log errors with messages such as
this is a bug and should not happen
.These errors have now been fixed, and configurations with query selectors such as the following work properly:
`
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.