Use deterministic order for type policy keyFields and field policy keyArgs #243
+44
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohandhruva
force-pushed
the
rdhruva/deterministic_sort
branch
from
1c57060 to
f837f3b
Compare
rohandhruva
force-pushed
the
rdhruva/deterministic_sort
branch
from
3cc1e5e to
cd0be1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
@typePolicyand@fieldPolicy, I noticed a few cache misses because thekeyFieldsandkeyArgswere not in the same order. When generating aCacheKeyin theCacheResolver, the generated key wasbar+foo, whereas the type policy generated it asfoo+bar.This PR uses deterministic sorting in both the keyFields of a type policy and keyArgs of a field policy.