-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync apollo portal server config to apollo quick start server #5134
sync apollo portal server config to apollo quick start server #5134
Conversation
WalkthroughThe latest update for Apollo, version 2.3.0, introduces a pivotal feature that synchronizes configurations between the Apollo portal and quick start servers. Additionally, enhancements in server compression, Tomcat settings, and session cookie configurations are included to improve performance and security. Changes
Poem
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Files skipped from review due to trivial changes (1)
Additional Context UsedLanguageTool (2)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Out of diff range and nitpick comments (2)
CHANGES.md (2)
Line range hint
1-1
: Add a blank line after the "Release Notes." heading for better readability.Release Notes. +
Line range hint
8-8
: Add blank lines around the list of changes to improve readability and adhere to Markdown best practices.Apollo 2.3.0 + ------------------
@@ -10,7 +10,7 @@ Apollo 2.3.0 | |||
* [Fix the issue that the length of private namespaces are mis-calculated](https://github.com/apolloconfig/apollo/pull/5078) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the spelling of "mis-calculated" to "miscalculated".
- mis-calculated
+ miscalculated
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
* [Fix the issue that the length of private namespaces are mis-calculated](https://github.com/apolloconfig/apollo/pull/5078) | |
* [Fix the issue that the length of private namespaces are miscalculated](https://github.com/apolloconfig/apollo/pull/5078) |
What's the purpose of this PR
The apollo quick start uses a standalone application.yml config file under apollo-assembly module which lacks some configurations. This pr aims to sync these missing configurations.
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.Summary by CodeRabbit