Otel #3
Open
Otel #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced centralized error handling with `TimeFusionError` enum in new `error.rs` module - Updated `main.rs` and `database.rs` to use custom `Result` type for consistent error propagation - Added `flush_pending_writes` to `Database` for ensuring data consistency during shutdown - Improved graceful shutdown in `main.rs` with database write monitoring and proper channel handling - Removed unused `AppInfo` struct and `shutdown_tx` from `AppState` to eliminate dead code warnings - Fixed move errors and unused variable warnings related to `shutdown_tx` and `shutdown_rx` - Updated `lib.rs` to export `error` module
…ype safety - Replaced anyhow::Result with custom TimeFusionError in columns() - Improved schema validation with runtime checks instead of asserts - Updated imports to include error module and removed unused serde_json::json
…n Config - Updated Config to use String instead of Option<String> for aws_access_key_id and aws_secret_access_key - Modified Config::from_env() to fail if AWS credentials are missing - Updated Database::new() to pass required credentials to register_project() - Simplified Database::new_for_test() to use required config credentials
- Updated insert_records_batch to deserialize RecordBatches into OtelLogsAndSpans - Added validation for each record using OtelLogsAndSpans::validate() - Ensured write operation only proceeds if all records are valid - Included serde_arrow::SchemaLike for deserialization support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR wires up OpenTelemetry tracing and metrics across the entire service.
telemetry.rsTracerProvidertraitEnsures
SdkTracerProvider::tracer(...)compiles correctly.ResourceIncludes your service name and project key.
tracing-subscriberRoutes all
tracingspans into OTLP.database.rsAdds
#[tracing::instrument]spans to all public methods, capturing key parameters:newnew_for_testcreate_session_contextsetup_session_contextregister_pg_settings_tableregister_set_config_udfstart_pgwire_serverresolve_tableinsert_records_batchinsert_recordsregister_projectEach span records important fields (e.g.,
project_id, batch sizes,port, etc.) without changing existing logic.Closes #
How to test
Checklist