-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Integrate browserforge fingerprints #829
Merged
Merged
Changes from 7 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
b0d52f2
Draft of integration of browserforge fingerprint generation.
Pijukatel be15847
Works with page.evaluate.
Pijukatel a9415ec
Use add_init_script
Pijukatel 36727a1
WIP
Pijukatel 42eff80
Fix format, type check and tests.
Pijukatel 998cbb6
Fix rootcause for flakiness in fingerprint generation
Pijukatel e1025c8
Use browserforge.injector code for fingerprints
Pijukatel 33fdd6e
Merge remote-tracking branch 'origin/master' into integrate-browserfo…
Pijukatel 85ba877
Regenerate poetry lock after merge
Pijukatel 6e35c1d
Remove unintentional change to headless test
Pijukatel 3f96456
Merge branch 'master' into integrate-browserforge-fingerprints
Pijukatel ddfabea
chore: revert React version bump
barjin 3d37bca
Merge remote-tracking branch 'origin/master' into integrate-browserfo…
Pijukatel 1b8e6a3
Add ScreenFingerprint and NavigatorFingerprint
Pijukatel 9828a36
Add Fingerprint and their options types
Pijukatel f733c07
Add adapter tests
Pijukatel 97011d9
Integrate into pw_crawler
Pijukatel debe900
Further integration into our code.
Pijukatel 3d8340c
Finalize draft.
Pijukatel 3d9b170
Set fiongerprint generator as top level argument to pw crawler
Pijukatel 25aa4e2
Revert unnecessary change to function doc string.
Pijukatel 5e46b78
Make test adapter-generic.
Pijukatel 69b6974
Add types to __init__ if fingerprint_suite
Pijukatel 27479be
Remove FingerprintGeneratorOptions
Pijukatel 751f67c
Merge remote-tracking branch 'origin/master' into integrate-browserfo…
Pijukatel 1cbadb0
Review commnets
Pijukatel 8e44acd
Handle inconsistent result from browserforge fingerprint generator
Pijukatel d8001e7
Apply suggestions from code review
Pijukatel 07acbfa
Docs
Pijukatel 866fe98
Make sure browserforge files are downloaded before tests.
Pijukatel b3eee4f
Merge remote-tracking branch 'origin/master' into integrate-browserfo…
Pijukatel 5c15db1
Review comments
Pijukatel fa9b0f9
Merge remote-tracking branch 'origin/master' into integrate-browserfo…
Pijukatel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This can be simpler if we decide to rely purely on browserforge and remove our own header generation. )