Skip to content

feat: header facelift v2 #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2025
Merged

feat: header facelift v2 #1676

merged 4 commits into from
Jul 9, 2025

Conversation

katzino
Copy link
Contributor

@katzino katzino commented Jul 9, 2025

closes https://github.com/apify/apify-web/issues/4926

  • reverts back reverted changes 😅 from feat: header facelift #1662
  • adds precautions to style overrides caused by different CSS classes extractions in other repositories
  • finally fixes crashing CLI/SDKs pages by syncing @docusaurus dependencies to ^3.7.0 (there was version mismatch that caused react providers not being recognized)

@katzino katzino added this to the 118th sprint - Web Team milestone Jul 9, 2025
@katzino katzino requested review from HonzaTuron and jbartadev July 9, 2025 09:24
@katzino katzino self-assigned this Jul 9, 2025
@katzino katzino added the t-web Issues with this label are in the ownership of the web team. label Jul 9, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Mobile Sidebar Closes on Search Click

Clicking the search bar in the mobile sidebar incorrectly closes the sidebar instead of activating search functionality. This is caused by the onSearchClick handler, passed to the SearchBar component, which calls event.preventDefault() and mobileSidebar.toggle(), rendering mobile search unusable.

apify-docs-theme/src/theme/Navbar/MobileSidebar/Header/index.jsx#L15-L42

function onSearchClick(event) {
event.preventDefault();
mobileSidebar.toggle();
}
return (
<>
<div className="navbar-sidebar__brand">
<NavbarLogo />
<button
type="button"
className="clean-btn navbar-sidebar__close"
onClick={mobileSidebar.toggle}
aria-label="Close navigation bar"
>
<IconClose />
</button>
</div>
<div className="navbar-sidebar__actions">
<div className="navbar-sidebar__actions__container">
<NavbarCTA />
{!searchBarItem && (
<NavbarSearch>
<SearchBar onClick={onSearchClick} />
</NavbarSearch>
)}
</div>

Fix in CursorFix in Web


Comment bugbot run to trigger another review on this PR
Was this report helpful? Give feedback by reacting with 👍 or 👎

@apify-service-account
Copy link

Preview for this PR was built for commit a434c74 and is ready at https://pr-1676.preview.docs.apify.com!

@katzino katzino merged commit 90ff436 into master Jul 9, 2025
9 checks passed
@katzino katzino deleted the feat/header-facelift-v2 branch July 9, 2025 11:05
jbartadev added a commit that referenced this pull request Jul 21, 2025
* master:
  chore: publish new version of @apify/docs-theme [skip ci]
  fix: mobile search bar style override (#1677)
  chore: publish new version of @apify/docs-theme [skip ci]
  feat: header facelift v2 (#1676)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-web Issues with this label are in the ownership of the web team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants