This repository was archived by the owner on Aug 26, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Restructuring the compiler with intermediate data structures #5
Open
vvp
wants to merge
32
commits into
aphelionz:master
Choose a base branch
from
vvp:feat/compiler-work
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current iteration of js2amb works as a proof-of-concept, but the way it's designed will make the path forward hard if not impossible. This PR restructures the whole compiler, and introduces intermediate data structures for different compilation steps when parsing JS to Ambients.
Before this, parsing JS with Esprima and turning that directly to algebra-strings quickly ends up in if/else-heavy code, that doesn't cover all the possible combinations of JS expressions to corresponding Ambients primitives (basically, it's not compositional). This PR changes this by introducing few more AST-types to orchestrate the compilation steps better and enable compiler to do type checking and optimizations without hardcoding.
This is still work-in-progress, but wanted to let you know what does it look like and where is this going 🙂