Skip to content

Conversation

leon-inf
Copy link
Contributor

cherry picked from commit c620878

@leon-inf leon-inf added this to the Release 1.0.2 milestone Oct 15, 2025
@leon-inf leon-inf requested a review from a team as a code owner October 15, 2025 08:00
@apecloud-bot
Copy link
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.0

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Oct 15, 2025
@leon-inf
Copy link
Contributor Author

/nopick

@apecloud-bot apecloud-bot added the nopick Not auto cherry-pick when PR merged label Oct 15, 2025
@leon-inf
Copy link
Contributor Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 15, 2025
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 43.85965% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.02%. Comparing base (ba2ccb5) to head (71105fc).

Files with missing lines Patch % Lines
pkg/controller/instanceset/reconciler_update.go 40.74% 23 Missing and 9 partials ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.0    #9810      +/-   ##
===============================================
+ Coverage        59.94%   60.02%   +0.07%     
===============================================
  Files              493      493              
  Lines            54660    54673      +13     
===============================================
+ Hits             32768    32816      +48     
+ Misses           18881    18853      -28     
+ Partials          3011     3004       -7     
Flag Coverage Δ
unittests 60.02% <43.85%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test nopick Not auto cherry-pick when PR merged size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants