Skip to content

Conversation

leon-inf
Copy link
Contributor

No description provided.

@leon-inf leon-inf requested a review from a team as a code owner August 29, 2025 08:32
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 29, 2025
@apecloud-bot
Copy link
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.0

@leon-inf leon-inf requested a review from cjc7373 August 29, 2025 08:32
@leon-inf leon-inf added this to the Release 1.1.0 milestone Aug 29, 2025
@leon-inf
Copy link
Contributor Author

/pick release-1.0

@apecloud-bot apecloud-bot added the pick-1.0 Auto cherry-pick to release-1.0 when PR merged label Aug 29, 2025
@cjc7373
Copy link
Contributor

cjc7373 commented Aug 29, 2025

I suggest add a validation in cmpd controller to disallow both fields to be set, and also clarify this behaviour in api docs.

Copy link
Contributor

@zjx20 zjx20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to describe this behavior in the API doc.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Sep 1, 2025
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Sep 1, 2025
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Sep 1, 2025
@leon-inf
Copy link
Contributor Author

leon-inf commented Sep 1, 2025

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Sep 1, 2025
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.65%. Comparing base (0fe2b0d) to head (649c4aa).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/component/available.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9684      +/-   ##
==========================================
+ Coverage   59.49%   59.65%   +0.15%     
==========================================
  Files         551      551              
  Lines       59727    59730       +3     
==========================================
+ Hits        35536    35633      +97     
+ Misses      20955    20864      -91     
+ Partials     3236     3233       -3     
Flag Coverage Δ
unittests 59.65% <50.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leon-inf leon-inf merged commit 9364193 into main Sep 1, 2025
40 checks passed
@leon-inf leon-inf deleted the support/disable-available-with-role-and-phase branch September 1, 2025 07:50
@apecloud-bot
Copy link
Collaborator

/cherry-pick release-1.0

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/17371232831

apecloud-bot pushed a commit that referenced this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test pick-1.0 Auto cherry-pick to release-1.0 when PR merged size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants