-
Notifications
You must be signed in to change notification settings - Fork 237
chore: disable role and phase available conditions when probe is set explicitly #9684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Auto Cherry-pick Instructions
|
/pick release-1.0 |
I suggest add a validation in cmpd controller to disallow both fields to be set, and also clarify this behaviour in api docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to describe this behavior in the API doc.
/approve |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9684 +/- ##
==========================================
+ Coverage 59.49% 59.65% +0.15%
==========================================
Files 551 551
Lines 59727 59730 +3
==========================================
+ Hits 35536 35633 +97
+ Misses 20955 20864 -91
+ Partials 3236 3233 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/cherry-pick release-1.0 |
🤖 says: cherry pick action finished successfully 🎉! |
No description provided.