Skip to content

fix: do not select the replicas being scaled as the data source #9639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2025
Merged

fix: do not select the replicas being scaled as the data source #9639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions controllers/apps/component/transformer_component_workload_ops.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,9 @@ func (r *componentWorkloadOps) buildDataReplicationTask() error {

// replicas to be created
newReplicas := r.desiredCompPodNameSet.Difference(r.runningItsPodNameSet).UnsortedList()
if len(newReplicas) == 0 {
return nil
}

// replicas in provisioning that the data has not been loaded
provisioningReplicas, err := component.GetReplicasStatusFunc(r.protoITS, func(s component.ReplicaStatus) bool {
Expand All @@ -273,17 +276,13 @@ func (r *componentWorkloadOps) buildDataReplicationTask() error {
return err
}

replicas := append(slices.Clone(newReplicas), provisioningReplicas...)
if len(replicas) == 0 {
return nil
}

// the source replica
source, err := r.sourceReplica(r.synthesizeComp.LifecycleActions.DataDump)
source, err := r.sourceReplica(r.synthesizeComp.LifecycleActions.DataDump, provisioningReplicas)
if err != nil {
return err
}

replicas := append(slices.Clone(newReplicas), provisioningReplicas...)
parameters, err := component.NewReplicaTask(r.synthesizeComp.FullCompName, r.synthesizeComp.Generation, source, replicas)
if err != nil {
return err
Expand All @@ -298,16 +297,23 @@ func (r *componentWorkloadOps) buildDataReplicationTask() error {
return createOrUpdateEnvConfigMap(transCtx, r.dag, parameters)
}

func (r *componentWorkloadOps) sourceReplica(dataDump *appsv1.Action) (*corev1.Pod, error) {
func (r *componentWorkloadOps) sourceReplica(dataDump *appsv1.Action, provisioningReplicas []string) (*corev1.Pod, error) {
pods, err := component.ListOwnedPods(r.transCtx.Context, r.cli,
r.synthesizeComp.Namespace, r.synthesizeComp.ClusterName, r.synthesizeComp.Name)
if err != nil {
return nil, err
}
if len(provisioningReplicas) > 0 {
// exclude provisioning replicas
pods = slices.DeleteFunc(pods, func(pod *corev1.Pod) bool {
return slices.Contains(provisioningReplicas, pod.Name)
})
}
if len(pods) > 0 {
if len(dataDump.Exec.TargetPodSelector) == 0 {
dataDump.Exec.TargetPodSelector = appsv1.AnyReplica
}
// TODO: idempotence for provisioning replicas
pods, err = lifecycle.SelectTargetPods(pods, nil, dataDump)
if err != nil {
return nil, err
Expand Down