Skip to content

Conversation

sophon-zt
Copy link
Contributor

No description provided.

@sophon-zt sophon-zt requested a review from a team as a code owner July 16, 2025 10:22
@sophon-zt sophon-zt linked an issue Jul 16, 2025 that may be closed by this pull request
@apecloud-bot
Copy link
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.0

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 16, 2025
@sophon-zt sophon-zt added the pick-1.0 Auto cherry-pick to release-1.0 when PR merged label Jul 16, 2025
@apecloud-bot apecloud-bot added the approved PR Approved Test label Jul 17, 2025
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.85%. Comparing base (ffb5f17) to head (c6a947c).
⚠️ Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
...s/apps/component/transformer_component_workload.go 0.00% 1 Missing and 1 partial ⚠️
pkg/controller/configuration/utils.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9544      +/-   ##
==========================================
+ Coverage   59.76%   59.85%   +0.08%     
==========================================
  Files         518      518              
  Lines       56320    56324       +4     
==========================================
+ Hits        33661    33710      +49     
+ Misses      19633    19603      -30     
+ Partials     3026     3011      -15     
Flag Coverage Δ
unittests 59.85% <0.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

if component.IsKBAgentContainer(&c) {
continue
}
if configctrl.IsConfigManagerContainer(c.Name) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not introduce further dependencies on configuration within the cluster controller.

@sophon-zt
Copy link
Contributor Author

/approve

Copy link

github-actions bot commented Sep 8, 2025

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment

@github-actions github-actions bot added the Stale label Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test pick-1.0 Auto cherry-pick to release-1.0 when PR merged size/XS Denotes a PR that changes 0-9 lines. Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

config-manager image not updated after upgrading KB.

4 participants