-
Notifications
You must be signed in to change notification settings - Fork 237
chore: rollback service account name when upgrading componentdefinition #9518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: rollback service account name when upgrading componentdefinition #9518
Conversation
Auto Cherry-pick Instructions
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment |
999e169
to
8e2364b
Compare
35c0a3a
to
a8ea87f
Compare
a8ea87f
to
f9a98f1
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9518 +/- ##
==========================================
+ Coverage 59.60% 60.12% +0.52%
==========================================
Files 551 551
Lines 59739 60326 +587
==========================================
+ Hits 35607 36274 +667
+ Misses 20888 20768 -120
- Partials 3244 3284 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
In #8328, pod's serviceaccount name has been changed to
kb-{cmpdName}
so that pods with the same cmpd can share one serviceaccount. However, this leads to a problem that when upgrading a component's cmpd (by changing the.spec.compDef
field in component object), it will trigger a pod restart since serviceaccount has changed.To avoid pod restarting, we can rollback a serviceaccount change if the underlying policyrules do not change.
An alternate solution is to change the serviceaccount name rule back to
kb-{clusterName}-{componentName}
. But this way can lead to a pod restart to all existing clusters.