chore: introduce the shard template for heterogeneous shards #9491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto Cherry-pick Instructions |
|
/nopick |
leon-inf
force-pushed
the
support/sharding-template
branch
2 times, most recently
from
2d1b80d to
b4d2dcb
Compare
leon-inf
force-pushed
the
support/sharding-template
branch
2 times, most recently
from
ede3339 to
e79fbfa
Compare
leon-inf
force-pushed
the
support/sharding-template
branch
from
e79fbfa to
39a2086
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9491 +/- ##
==========================================
+ Coverage 59.51% 59.81% +0.29%
==========================================
Files 517 518 +1
Lines 55432 55913 +481
==========================================
+ Hits 32993 33445 +452
- Misses 19471 19485 +14
- Partials 2968 2983 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leon-inf
force-pushed
the
support/sharding-template
branch
from
2d4a6da to
88c7186
Compare
leon-inf
requested review from
a team,
ldming,
wangyelei and
zjx20
as code owners
zjx20
reviewed
Jun 30, 2025
pkg/controller/sharding/types.go
Outdated
| } | ||
| } | ||
|
|
||
| func (t *shardTemplate) create(generator *shardIDGenerator, shardingName string, cnt int) error { |
There was a problem hiding this comment.
Will the name be different? How about using generator.shardingName directly instead of passing it via args?
| for i, shardingComp := range shardingCompList { | ||
| if shardingComp.Name == r.ComponentName { | ||
| compSpec = shardingCompList[i] | ||
| return compSpec, nil |
There was a problem hiding this comment.
return shardingCompList[i], nil
leon-inf
force-pushed
the
support/sharding-template
branch
from
9d8f283 to
e46f393
Compare
leon-inf
force-pushed
the
support/sharding-template
branch
from
e46f393 to
a5e98e0
Compare
zjx20
reviewed
Jul 1, 2025
| func precheck(sharding *appsv1.ClusterSharding) error { | ||
| shards := int32(0) | ||
| shardIDs := sets.NewString() | ||
| for _, tpl := range sharding.ShardTemplates { |
There was a problem hiding this comment.
Check the uniqueness of tpl.Name.
pkg/controller/sharding/utils.go
Outdated
|
|
||
| func shardNamesTakeOverByTemplate(clusterName string, sharding *appsv1.ClusterSharding) []string { | ||
| result := make([]string, 0) | ||
| for name := range maps.Keys(shardNamesTakeOverByTemplateMap(clusterName, sharding)) { |
There was a problem hiding this comment.
The call to maps.Keys() is redundant.
zjx20
approved these changes
Jul 1, 2025
|
/approve |
apecloud-bot
approved these changes
Jul 1, 2025
leon-inf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.