[YUNIKORN-3287] Support Gateway API HTTPRoute in Helm chart - #231
PoiBlackTea wants to merge 1 commit into
Conversation
|
Hi @wilfred-s @manirajv06 |
wilfred-s
left a comment
There was a problem hiding this comment.
The change looks good except for the extra manifest added. Should not be added.
An extra manifest can always be added if and when it is needed for new features. If we never add experimental things it it will just be a maintenance burden.
c1e375a to
e322f4c
Compare
Got it, I've dropped the extraManifests commit. Please take a look. Thanks. |
| # - chart-example.local | ||
|
|
||
| # Custom routing rules. If empty, a default rule mapping to the UI service is used. | ||
| # rules: [] |
There was a problem hiding this comment.
why this is configurable, should not it always go to webservice?
There was a problem hiding this comment.
While it's true that the ultimate destination is always the YuniKorn webservice, the Gateway API's rules offer powerful traffic management features that users might need to configure.
By allowing rules to be overridden, users can leverage advanced Gateway API features, such as:
- URLRewrite / Path redirects (e.g., rewriting /yunikorn to /)
If rules is left empty (which is the default), we automatically generate a default rule that maps all traffic directly to the webservice. This keeps it simple out of the box while preserving the full flexibility of the Gateway API for advanced ingress requirements.
There was a problem hiding this comment.
ok, thanks for the clarification
Description
This PR introduces first-class support for the Kubernetes Gateway API (
HTTPRoute) in the YuniKorn Helm chart, addressing [YUNIKORN-3287].Key additions:
httproute.yamlto deploy anHTTPRouteresource, enabling modern ingress routing to the YuniKorn Web UI.All features are disabled by default to ensure backward compatibility.
Generated by Antigravity IDE.
Type of change
Jira issue
Jira ID : https://issues.apache.org/jira/browse/YUNIKORN-3287
AI Tooling
How has this been tested?
helm templategenerates correctHTTPRouteand custom resources based onvalues.yamlinputs.gateway.networking.k8s.io) and an NGINX Gateway on Minikube.helm upgradewithhttpRoute.enabled=trueand customhostnames.kubectl port-forwardto the Gateway service and verified thatcurlto the YuniKorn Web UI (/) and REST API (/ws/v1/clusters) successfully returned HTTP 200, and rejected invalid hostnames with HTTP 404.Questions:
release-noteslabel.