Skip to content

Conversation

@manirajv06
Copy link
Contributor

@manirajv06 manirajv06 commented Oct 30, 2025

What is this PR for?

Collect all allocation running in the queue after applying filters

  1. Skip allocations which does not have single matching resource type with preemptable resource
  2. Skip DS allocations
  3. Skip Already preemption allocations
  4. Skip already released allocations

and sort the same based on the following criteria:

  1. By type (regular pods, opted out pods, driver/owner pods),
  2. By priority (least priority ask placed first),
  3. By Create time or age of the ask (younger ask placed first),
  4. By resource (ask with lesser allocated resources placed first)

In addition, Refactored some of the common preemption related utilities as well.

What type of PR is it?

  • - Feature

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-3143

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@manirajv06 manirajv06 self-assigned this Oct 30, 2025
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 97.32143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.01%. Comparing base (fde27e5) to head (2d6c303).

Files with missing lines Patch % Lines
pkg/scheduler/objects/quota_change_preemptor.go 96.42% 1 Missing and 1 partial ⚠️
pkg/scheduler/objects/preemption_utilities.go 96.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1040      +/-   ##
==========================================
+ Coverage   80.91%   81.01%   +0.09%     
==========================================
  Files          99      101       +2     
  Lines       12882    12955      +73     
==========================================
+ Hits        10424    10495      +71     
- Misses       2201     2202       +1     
- Partials      257      258       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant