Skip to content

Conversation

@manirajv06
Copy link
Contributor

What is this PR for?

Added precondition checks to decide whether to proceed with preemption process or not

What type of PR is it?

  • - Feature

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-3141

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@manirajv06 manirajv06 self-assigned this Oct 24, 2025
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.48%. Comparing base (6bd254c) to head (e881ccd).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1038      +/-   ##
==========================================
+ Coverage   81.46%   81.48%   +0.02%     
==========================================
  Files         101      102       +1     
  Lines       13308    13337      +29     
==========================================
+ Hits        10841    10868      +27     
- Misses       2208     2209       +1     
- Partials      259      260       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pbacsko
Copy link
Contributor

pbacsko commented Oct 30, 2025

@manirajv06 please rebase the changes

Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM, pending rebase

@manirajv06
Copy link
Contributor Author

Rebased the changes.

@manirajv06 manirajv06 closed this in 0d896fd Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants