Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for normal MLA kernel #17624

Merged
merged 5 commits into from
Feb 20, 2025

Conversation

annanyapr
Copy link
Contributor

Have refactored _attention_prefill_ragged to allow for different v dimension from q/k dimension. This can be used for MLA attention in deepseek models.

@annanyapr
Copy link
Contributor Author

@MasterJH5574 can you take a look?

@annanyapr annanyapr changed the title Refactored code to allow for different v dimension from q/k dimension Added support for normal MLA kernel Feb 17, 2025
@annanyapr
Copy link
Contributor Author

@MasterJH5574 TVM seems to building correctly and tvm/tests/python/relax/test_runtime_builtin_paged_attention_kv_cache_tir.py seems to be working fine

Copy link
Contributor

@MasterJH5574 MasterJH5574 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! We are good to go after CI passes.

@MasterJH5574 MasterJH5574 merged commit 6d92f2a into apache:main Feb 20, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants