Skip to content

Conversation

@Dayuxiaoshui
Copy link

  • Add repr parameter to c_class() decorator (default: True)
  • Add repr parameter to field() function (default: True)
  • Implement method_repr() to generate repr methods
  • Generated repr format: ClassName(field1=value1, field2=value2, ...)
  • Fields with repr=False are excluded from the representation

This implements part of #356 dataclass feature parity.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Dayuxiaoshui, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the @c_class decorator by introducing automatic __repr__ generation, similar to Python's built-in dataclasses. It provides new repr parameters at both the class and field levels, allowing developers to customize the string representation of their C++-backed Python objects for improved debugging and readability. This moves the c_class functionality closer to full dataclass feature parity.

Highlights

  • New 'repr' parameter in @c_class decorator: A new repr parameter (defaulting to True) has been added to the c_class() decorator, allowing control over automatic __repr__ generation for the decorated class.
  • New 'repr' parameter in field() function: The field() function now includes a repr parameter (defaulting to True), enabling fine-grained control over whether individual fields are included in the generated __repr__ output.
  • Dynamic repr method generation: A new utility function, method_repr(), has been implemented to dynamically generate __repr__ methods for c_class instances. This method collects fields from the class hierarchy and formats them as ClassName(field1=value1, field2=value2, ...).
  • Exclusion of fields from repr: Fields marked with repr=False in their field() definition will be excluded from the automatically generated __repr__ string.
  • Dataclass feature parity: These changes contribute to achieving greater feature parity with standard Python dataclasses, specifically addressing issue How far are we from @dataclass #356.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for automatic __repr__ generation for @c_class dataclasses, which is a great step towards feature parity with standard Python dataclasses. The implementation is clean, adding repr parameters to the @c_class decorator and field() function to control the behavior. The dynamic generation of the __repr__ method is well-handled. I've included a couple of suggestions in python/tvm_ffi/dataclasses/_utils.py to improve code maintainability by reducing duplication and to enhance code style for better readability.

@Dayuxiaoshui
Copy link
Author

@tqchen cc

@junrushao
Copy link
Member

Please add some unittests

@Dayuxiaoshui
Copy link
Author

@junrushao I am ready, please review it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants