[fix] service.bat JvmOptions9 - FollowUp on Improve CVE-2024-56337 protection #858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- service.bat:
- fix JvmOptions9 to followup according changes in catalina.bat
- improve legibility of JvmOptions9 parameter line
by introducing intermediate set variable JVM9_OPTIONS
- add comment to JVM9_OPTIONS settings
with hint to keep in line with catalina.bat
- catalina.bat:
- add comment to JDK_JAVA_OPTIONS --add-opens settings
with hint to keep in line with service.bat
mhoffrog
referenced
this pull request
May 20, 2025
Don't use reflection unless necessary. This means less impact for those using Tomcat in an embedded environment.
|
Docs for Commons Daemon Procrun mention, that JvmOptions9 can use the same two separators, that JvmOptions can use. Namely ";" and "#". Currently we use ";" for JvmOptions and "#" for JvmOptions9. It might make sense to use ";" for both for consistency. |
…parator
- service.bat:
- replace '#' by ';' as option separator to make JvmOptions9
consistent with the JvmOptions parameter coding
@rainerjung Thanks for this hint - Done! |
michael-o
reviewed
May 21, 2025
- catalina.bat,
service.bat:
- replace phrasing "- KEEP in line with ..."
by "- ensure to keep it in line with ..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: Commit 0c75cd1 by @markt-asf
Issue: The commit referred did miss to keep
service.batJvmOptions9 in line with the change of catalina.bat made by that commit.Changes:
service.bat:
catalina.bat:
Test result: (updated after commit 3767fd5)
