Skip to content

THRIFT-5712 - Added Dart 3 Compatibility #3258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

THRIFT-5712 - Added Dart 3 Compatibility #3258

wants to merge 1 commit into from
+377 −340

Conversation

@MartinHaimberger
Copy link
Contributor

@MartinHaimberger MartinHaimberger commented Nov 28, 2025 •
edited
Loading

Since the pullrequest #2930 got stuck, i started over fresh and implemented it myself.

Since there was already an issue (https://issues.apache.org/jira/browse/THRIFT-5712) i commented there.

  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
    The generated classes now also expose optional values, so for that a customization will be necessary. But this is a new language feature so there is no way around.
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@Jens-G Jens-G changed the title - THRIFT-5712 - Added Dart 3 Compatibility THRIFT-5712 - Added Dart 3 Compatibility Nov 28, 2025
@Jens-G Jens-G added the dart Pull requests that update Dart code label Nov 28, 2025
Jens-G
Jens-G requested changes Nov 28, 2025
View reviewed changes
Copy link
Member

@Jens-G Jens-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, thanks for the contribution - much appreciated! I made a few comments for things that I foiund during rather quick review.

Since it is a large changeset, I would love a second opinion form someone like @mark-erickson

lib/dart/lib/src/browser/t_web_socket.dart
_socket.onOpen.listen(_onOpen);
_socket.onClose.listen(_onClose);
_socket.onMessage.listen(_onMessage);
_socket!.onError.listen(_onError);
Copy link
Member

@Jens-G Jens-G Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm personally not such a big fan of overriding null checks via ! because there is a reason why these checks exist in the first place. It's nice when code runs during the shiny weather, but it should not produce strange, hard to reproduce and hard to spot errors under heavy conditions.

Copy link
Contributor Author

@MartinHaimberger MartinHaimberger Nov 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

socket is created the line above, so it cant be null

@MartinHaimberger
Copy link
Contributor Author

MartinHaimberger commented Nov 28, 2025

First, thanks for the contribution - much appreciated! I made a few comments for things that I foiund during rather quick review.

Since it is a large changeset, I would love a second opinion form someone like @mark-erickson

Sure. I am happy to help. Any suggestions for improvement are always welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jens-G Jens-G Awaiting requested review from Jens-G

Assignees

No one assigned

Labels

dart Pull requests that update Dart code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MartinHaimberger @Jens-G